Changeset 57991 in vbox

Timestamp:

Oct 1, 2015 7:28:46 PM (9 years ago)

Author:

vboxsync

Message:

VBoxManage/VBoxManageDebugVM.cpp: Fixed hang when processing log groups starting with "h", e.g. "VBoxManage debugvm <VM Name> log --debug -hex".

File:

• trunk/src/VBox/Frontends/VBoxManage/VBoxManageDebugVM.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VBoxManage/VBoxManageDebugVM.cpp

@@ -211 +211 @@
         { "--release",      DEBUGVM_LOG_RELEASE, RTGETOPT_REQ_NOTHING }
     };
-    int rc = RTGetOptInit(&GetState, pArgs->argc, pArgs->argv, s_aOptions, RT_ELEMENTS(s_aOptions), 2, RTGETOPTINIT_FLAGS_OPTS_FIRST);
+    int rc = RTGetOptInit(&GetState, pArgs->argc, pArgs->argv, s_aOptions, RT_ELEMENTS(s_aOptions), 2,
+                          /*
+                           * Note: RTGETOPTINIT_FLAGS_NO_STD_OPTS is needed to not get into an infinite hang in the following
+                           *       while-loop when processing log groups starting with "h",
+                           *       e.g. "VBoxManage debugvm <VM Name> log --debug -hex".
+                           */
+                          RTGETOPTINIT_FLAGS_OPTS_FIRST | RTGETOPTINIT_FLAGS_NO_STD_OPTS);
     AssertRCReturn(rc, RTEXITCODE_FAILURE);
 
@@ -247 +253 @@
         strSettings.append(strTmp);
     }
+
+
 
     com::Bstr bstrSettings(strSettings);