Changeset 57970 in vbox

Timestamp:

Sep 30, 2015 2:56:34 PM (9 years ago)

Author:

vboxsync

Message:

Runtime: fixed parameters for RTUdpCreateClientSocket

Location:

trunk

Files:

• include/iprt/udp.h (modified) (1 diff)
• src/VBox/Runtime/r3/udp.cpp (modified) (3 diffs)
• src/VBox/Runtime/testcase/tstRTUdp-1.cpp (modified) (2 diffs)

trunk/include/iprt/udp.h

@@ -156 +156 @@
  * @param   pszAddress          The address to connect to.
  * @param   uPort               The port to connect to.
- * @param   pDefaultDstAddr     A default destination address for sending data
- *                              through this socket, can be NULL.
+ * @param   pLocalAddr          The local address to bind this socket to, can be
+ *                              NULL.
  * @param   pSock               Where to store the handle to the established connection.
  */
-RTR3DECL(int) RTUdpCreateClientSocket(const char *pszAddress, uint32_t uPort, PRTNETADDR pDefaultDstAddr, PRTSOCKET pSock);
+RTR3DECL(int) RTUdpCreateClientSocket(const char *pszAddress, uint32_t uPort, PRTNETADDR pLocalAddr, PRTSOCKET pSock);
 
 /** @} */

trunk/src/VBox/Runtime/r3/udp.cpp

@@ -688 +688 @@
 
 
-RTR3DECL(int) RTUdpCreateClientSocket(const char *pszAddress, uint32_t uPort, PRTNETADDR pDefaultDstAddr, PRTSOCKET pSock)
+RTR3DECL(int) RTUdpCreateClientSocket(const char *pszAddress, uint32_t uPort, PRTNETADDR pLocalAddr, PRTSOCKET pSock)
 {
     /*
@@ -695 +695 @@
     AssertReturn(uPort > 0, VERR_INVALID_PARAMETER);
     AssertPtrReturn(pszAddress, VERR_INVALID_POINTER);
+    AssertPtrReturn(pSock, VERR_INVALID_POINTER);
 
     /*
@@ -712 +713 @@
     {
         RTSocketSetInheritance(Sock, false /* fInheritable */);
-        rc = rtSocketBind(Sock, &Addr);
+        if (pLocalAddr)
+            rc = rtSocketBind(Sock, pLocalAddr);
         if (RT_SUCCESS(rc))
         {
-            if (pDefaultDstAddr)
-                rc = rtSocketConnect(Sock, pDefaultDstAddr, RT_SOCKETCONNECT_DEFAULT_WAIT);
+            rc = rtSocketConnect(Sock, &Addr, RT_SOCKETCONNECT_DEFAULT_WAIT);
             if (RT_SUCCESS(rc))
             {

trunk/src/VBox/Runtime/testcase/tstRTUdp-1.cpp

@@ -30 +30 @@
 #include <iprt/string.h>
 #include <iprt/test.h>
-
-#define RT_TEST_UDP_CLIENT_ADDRESS     "localhost"
-#define RT_TEST_UDP_CLIENT_PORT        52001
 
 /* Server address must be "localhost" */
@@ -99 +96 @@
     int rc;
     RTSOCKET hSocket;
-    RTTESTI_CHECK_RC(rc = RTUdpCreateClientSocket(RT_TEST_UDP_CLIENT_ADDRESS, RT_TEST_UDP_CLIENT_PORT, &ServerAddress, &hSocket),
-                     VINF_SUCCESS);
+    RTTESTI_CHECK_RC(rc = RTUdpCreateClientSocket(RT_TEST_UDP_LOCAL_HOST, RT_TEST_UDP_SERVER_PORT, NULL, &hSocket), VINF_SUCCESS);
     if (RT_SUCCESS(rc))
     {