Changeset 55139 in vbox

Timestamp:

Apr 8, 2015 2:32:33 PM (9 years ago)

Author:

vboxsync

Message:

FE/Qt: UIFramebuffer: validate NotifyUpdateImage parameters.

File:

• trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIFrameBuffer.cpp (modified) (2 diffs)

trunk/src/VBox/Frontends/VirtualBox/src/runtime/UIFrameBuffer.cpp

@@ -520 +520 @@
     , m_pMachineView(NULL)
     , m_iWinId(0)
-    , m_fUpdatesAllowed(true)
+    , m_fUpdatesAllowed(false)
     , m_fUnused(false)
     , m_fAutoEnabled(false)
@@ -831 +831 @@
         return E_FAIL;
     }
-
-    /* Directly update m_image: */
-    if (m_fUpdatesAllowed)
+    /* Directly update m_image if update fits: */
+    if (   m_fUpdatesAllowed
+        && uX + uWidth <= (ULONG)m_image.width()
+        && uY + uHeight <= (ULONG)m_image.height())
     {
         /* Copy to m_image: */