Changeset 50063 in vbox

Timestamp:

Jan 13, 2014 4:48:33 PM (11 years ago)

Author:

vboxsync

Message:

VBoxService/VBoxServiceControlSession.cpp: Added a to-do.

File:

• trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp (modified) (4 diffs)

trunk/src/VBox/Additions/common/VBoxService/VBoxServiceControlSession.cpp

@@ -2009 +2009 @@
                                     | RTPROC_FLAGS_HIDDEN; /** @todo More flags from startup info? */
 
+                /*
+                 * Create the session process' environment block.
+                 */
+                RTENV hEnv = NIL_RTENV;
+                if (RT_SUCCESS(rc))
+                {
+                    /** @todo At the moment a session process does not have the ability to use the
+                     *        per-session environment variables itself, only the session's guest
+                     *        processes do so. Implement that later, also needs tweaking of
+                     *        VbglR3GuestCtrlSessionGetOpen(). */
+                    rc = RTEnvClone(&hEnv, RTENV_DEFAULT);
+                }
+
 #if 0 /* Pipe handling not needed (yet). */
                 /* Setup pipes. */
@@ -2036 +2049 @@
 
                         if (RT_SUCCESS(rc))
-                        {
-                            /* Fork the thing. */
-                            /** @todo Do we need a custom environment block? */
-                            rc = RTProcCreateEx(pszExeName, papszArgs, RTENV_DEFAULT, uProcFlags,
+                            rc = RTProcCreateEx(pszExeName, papszArgs, hEnv, uProcFlags,
                                                 pSession->StdIn.phChild, pSession->StdOut.phChild, pSession->StdErr.phChild,
                                                 !fAnonymous ? pSession->StartupInfo.szUser : NULL,
                                                 !fAnonymous ? pSession->StartupInfo.szPassword : NULL,
                                                 &pSession->hProcess);
-                        }
 
                         if (RT_SUCCESS(rc))
@@ -2074 +2083 @@
                         hStdOutAndErr.enmType = RTHANDLETYPE_FILE;
 
-                        /** @todo Set custom/cloned guest session environment block. */
-                        rc = RTProcCreateEx(pszExeName, papszArgs, RTENV_DEFAULT, uProcFlags,
+                        rc = RTProcCreateEx(pszExeName, papszArgs, hEnv, uProcFlags,
                                             &hStdIn, &hStdOutAndErr, &hStdOutAndErr,
                                             !fAnonymous ? pSessionThread->StartupInfo.szUser : NULL,
@@ -2087 +2095 @@
                 }
 #endif
+                if (hEnv != NIL_RTENV)
+                    RTEnvDestroy(hEnv);
             }
         }