Changeset 49863 in vbox

Timestamp:

Dec 10, 2013 5:10:34 AM (11 years ago)

Author:

vboxsync

Message:

pxping_recv4: according to ping sources at www.opensource.apple.com
and contrary to icmp(4) man page, when sending with IP_HDRINCL the IP
header checksum must be set, and set to the host-order checksum of the
whole IP datagram including payload.

File:

• trunk/src/VBox/NetworkServices/NAT/pxping.c (modified) (1 diff)

trunk/src/VBox/NetworkServices/NAT/pxping.c

@@ -530 +530 @@
         IPH_OFFSET_SET(iph, ntohs(IPH_OFFSET(iph)));
         IPH_LEN_SET(iph, ntohs(IPH_LEN(iph)));
-#endif
+        /* wants checksum */
+        sum = inet_chksum_pbuf(p); /* sic(?) */
+        IPH_CHKSUM_SET(iph, sum);
+#else /* !RT_OS_DARWIN  */
         IPH_CHKSUM_SET(iph, 0); /* kernel will recalculate */
+#endif
     }
     else /* !pxping->hdrincl */