Changeset 45416 in vbox

Timestamp:

Apr 8, 2013 9:52:26 PM (11 years ago)

Author:

vboxsync

Message:

Build fix.

File:

• trunk/src/VBox/HostServices/GuestControl/service.cpp (modified) (4 diffs)

trunk/src/VBox/HostServices/GuestControl/service.cpp

@@ -474 +474 @@
 {
     ClientState(void)
-        : mID(0),
-          mSvcHelpers(NULL),
+        : mSvcHelpers(NULL),
+          mID(0),
           mFlags(0), mContextFilter(0),
           mHostCmdRc(VINF_SUCCESS), mHostCmdTries(0),
@@ -482 +482 @@
 
     ClientState(PVBOXHGCMSVCHELPERS pSvcHelpers, uint32_t uClientID)
-        : mID(uClientID),
-          mSvcHelpers(pSvcHelpers),
+        : mSvcHelpers(pSvcHelpers),
+          mID(uClientID),
           mFlags(0), mContextFilter(0),
           mHostCmdRc(VINF_SUCCESS), mHostCmdTries(0),
@@ -501 +501 @@
         if (curCmd != mHostCmdList.end())
             Dequeue(curCmd);
-    }
-
-    void Dequeue(HostCommand *pHostCmd)
-    {
-        AssertPtrReturnVoid(pHostCmd);
-
-        HostCmdListIter curItem = mHostCmdList.begin();
-        while (curItem != mHostCmdList.end())
-        {
-            if ((*curItem) == pHostCmd)
-            {
-                Dequeue(curItem);
-                break;
-            }
-
-            curItem++;
-        }
     }
 
@@ -679 +662 @@
 
         if (fRemove)
-            Dequeue(pHostCmd);
+        {
+            /** @todo Fix this (slow) lookup. Too late today. */
+            HostCmdListIter curItem = mHostCmdList.begin();
+            while (curItem != mHostCmdList.end())
+            {
+                if ((*curItem) == pHostCmd)
+                {
+                    Dequeue(curItem);
+                    break;
+                }
+
+                curItem++;
+            }
+        }
 
         LogFlowFunc(("[Client %RU32] Returned with rc=%Rrc\n", mID, rc));