Changeset 45310 in vbox

Timestamp:

Apr 3, 2013 2:54:09 PM (11 years ago)

Author:

vboxsync

Message:

PDMCritSectRw: Fixed shared leave bugs.

File:

• trunk/src/VBox/VMM/VMMAll/PDMAllCritSectRw.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/VMMAll/PDMAllCritSectRw.cpp

@@ -548 +548 @@
 
             if (   c > 0
-                || (u64State & RTCSRW_CNT_RD_MASK) == 0)
+                || (u64State & RTCSRW_CNT_WR_MASK) == 0)
             {
                 /* Don't change the direction. */
@@ -573 +573 @@
                 PVMCPU      pVCpu = VMMGetCpu(pVM);                 AssertPtr(pVCpu);
                 uint32_t    i     = pVCpu->pdm.s.cQueuedCritSectRwShrdLeaves++;
-                LogFlow(("PDMCritSectRwLeaveShared: [%d]=%p => R3\n", i, pThis));
+                LogFlow(("PDMCritSectRwLeaveShared: [%d]=%p => R3 c=%d (%#llx)\n", i, pThis, c, u64State));
                 AssertFatal(i < RT_ELEMENTS(pVCpu->pdm.s.apQueuedCritSectRwShrdLeaves));
                 pVCpu->pdm.s.apQueuedCritSectRwShrdLeaves[i] = MMHyperCCToR3(pVM, pThis);
@@ -580 +580 @@
                 STAM_REL_COUNTER_INC(&pVM->pdm.s.StatQueuedCritSectLeaves);
                 STAM_REL_COUNTER_INC(&pThis->s.StatContentionRZLeaveShared);
+                break;
 #endif
             }