Changeset 41642 in vbox

Timestamp:

Jun 11, 2012 10:30:54 AM (12 years ago)

Author:

vboxsync

Message:

VBoxGuest: Use the EventSpinlock when setting the mouse callback and made the ISR take down the callback info while owning that spinlock. Cleanups.

Location:

trunk

Files:

• include/VBox/VBoxGuest.h (modified) (3 diffs)
• src/VBox/Additions/WINNT/Mouse/NT5/VBoxMFInternal.cpp (modified) (1 diff)
• src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.cpp (modified) (1 diff)
• src/VBox/Additions/common/VBoxGuest/VBoxGuest.cpp (modified) (6 diffs)
• src/VBox/Additions/common/VBoxGuest/VBoxGuestInternal.h (modified) (1 diff)

trunk/include/VBox/VBoxGuest.h

@@ -312 +312 @@
 #define VBOXGUEST_IOCTL_WRITE_CORE_DUMP             VBOXGUEST_IOCTL_CODE(9, sizeof(VBoxGuestWriteCoreDump))
 
-/** IOCTL to VBoxGuest to update the mouse status features. */
-# define VBOXGUEST_IOCTL_SET_MOUSE_STATUS         VBOXGUEST_IOCTL_CODE_(10, sizeof(uint32_t))
-
 /** Input and output buffer layout of the VBOXGUEST_IOCTL_WRITE_CORE
  *  request. */
@@ -324 +321 @@
 AssertCompileSize(VBoxGuestWriteCoreDump, 4);
 
+/** IOCTL to VBoxGuest to update the mouse status features. */
+# define VBOXGUEST_IOCTL_SET_MOUSE_STATUS         VBOXGUEST_IOCTL_CODE_(10, sizeof(uint32_t))
 
 #ifdef VBOX_WITH_HGCM
@@ -362 +361 @@
 #endif /* VBOX_WITH_HGCM */
 
-typedef DECLCALLBACK(void) FNVBOXMOUSENOTIFYCB(void *pvContext);
-typedef FNVBOXMOUSENOTIFYCB *PFNVBOXMOUSENOTIFYCB;
+/** IOCTL to for setting the mouse driver callback. (kernel only)  */
+#define VBOXGUEST_IOCTL_SET_MOUSE_NOTIFY_CALLBACK   VBOXGUEST_IOCTL_CODE_(31, sizeof(VBoxGuestMouseSetNotifyCallback))
+
+/** Input buffer for VBOXGUEST_IOCTL_INTERNAL_SET_MOUSE_NOTIFY_CALLBACK. */
 typedef struct VBoxGuestMouseSetNotifyCallback
 {
-    PFNVBOXMOUSENOTIFYCB pfnNotify;
-    void *pvNotify;
+    /**
+     * Mouse notification callback.
+     *
+     * @param   pvUser      The callback argument.
+     */
+    DECLR0CALLBACKMEMBER(void,  pfnNotify, (void *pvUser));
+    /** The callback argument*/
+    void                       *pvUser;
 } VBoxGuestMouseSetNotifyCallback;
 
-#define VBOXGUEST_IOCTL_INTERNAL_SET_MOUSE_NOTIFY_CALLBACK   VBOXGUEST_IOCTL_CODE_(31, sizeof(VBoxGuestMouseSetNotifyCallback))
 
 #ifdef RT_OS_OS2

trunk/src/VBox/Additions/WINNT/Mouse/NT5/VBoxMFInternal.cpp

@@ -150 +150 @@
     CbInfo.pfnNotify = fRegister ? vboxNewProtMouseEventCb : NULL;
 
-    NTSTATUS Status = vboxGdcSubmit(VBOXGUEST_IOCTL_INTERNAL_SET_MOUSE_NOTIFY_CALLBACK, &CbInfo, sizeof (CbInfo));
+    NTSTATUS Status = vboxGdcSubmit(VBOXGUEST_IOCTL_SET_MOUSE_NOTIFY_CALLBACK, &CbInfo, sizeof (CbInfo));
     if (!NT_SUCCESS(Status))
     {

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest-win.cpp

@@ -843 +843 @@
     switch (uCmd)
     {
-        case VBOXGUEST_IOCTL_INTERNAL_SET_MOUSE_NOTIFY_CALLBACK:
+        case VBOXGUEST_IOCTL_SET_MOUSE_NOTIFY_CALLBACK:
         {
             PVOID pvBuf = pStack->Parameters.Others.Argument1;

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuest.cpp

@@ -727 +727 @@
         pDevExt->acMouseFeatureUsage[i] = 0;
     pDevExt->fMouseStatus = 0;
-    pDevExt->MouseSetNotifyCallback.pfnNotify = NULL;
-    pDevExt->MouseSetNotifyCallback.pvNotify = NULL;
+    pDevExt->MouseNotifyCallback.pfnNotify = NULL;
+    pDevExt->MouseNotifyCallback.pvUser = NULL;
     pDevExt->cISR = 0;
 
@@ -1248 +1248 @@
 {
     Log(("VBoxGuestCommonIOCtl: SET_MOUSE_NOTIFY_CALLBACK\n"));
-    RTSpinlockAcquire(pDevExt->SessionSpinlock);
-    ASMAtomicWriteNullPtr(&pDevExt->MouseSetNotifyCallback.pfnNotify);
-    pDevExt->MouseSetNotifyCallback.pvNotify = pNotify->pvNotify;
-    ASMAtomicWritePtr(&pDevExt->MouseSetNotifyCallback.pfnNotify,
-                      pNotify->pfnNotify);
-    RTSpinlockReleaseNoInts(pDevExt->SessionSpinlock);
-    /* Make sure no one is referencing the old data - hacky but should be
+
+    RTSpinlockAcquire(pDevExt->EventSpinlock);
+    pDevExt->MouseNotifyCallback = *pNotify;
+    RTSpinlockReleaseNoInts(pDevExt->EventSpinlock);
+
+    /* Make sure an active ISR is referencing the old data - hacky but should be
      * effective. */
-    while (pDevExt->cISR > 0);
+    while (pDevExt->cISR > 0)
+        ASMNopPause();
+
     return VINF_SUCCESS;
 }
@@ -2540 +2541 @@
 
 #ifndef RT_OS_WINDOWS  /* Windows has its own implementation of this. */
-            case VBOXGUEST_IOCTL_INTERNAL_SET_MOUSE_NOTIFY_CALLBACK:
+            case VBOXGUEST_IOCTL_SET_MOUSE_NOTIFY_CALLBACK:
                 CHECKRET_RING0("SET_MOUSE_NOTIFY_CALLBACK");
-                CHECKRET_SIZE("SET_MOUSE_NOTIFY_CALLBACK",
-                           sizeof(VBoxGuestMouseSetNotifyCallback));
+                CHECKRET_SIZE("SET_MOUSE_NOTIFY_CALLBACK", sizeof(VBoxGuestMouseSetNotifyCallback));
                 rc = VBoxGuestCommonIOCtl_SetMouseNotifyCallback(pDevExt, (VBoxGuestMouseSetNotifyCallback *)pvData);
                 break;
@@ -2639 +2639 @@
 bool VBoxGuestCommonISR(PVBOXGUESTDEVEXT pDevExt)
 {
-    bool                    fMousePositionChanged = false;
-    VMMDevEvents volatile  *pReq                  = pDevExt->pIrqAckEvents;
-    int                     rc                    = 0;
-    bool                    fOurIrq;
+#ifndef RT_OS_WINDOWS
+    VBoxGuestMouseSetNotifyCallback MouseNotifyCallback   = { NULL, NULL };
+#endif
+    bool                            fMousePositionChanged = false;
+    VMMDevEvents volatile          *pReq                  = pDevExt->pIrqAckEvents;
+    int                             rc                    = 0;
+    bool                            fOurIrq;
 
     /*
@@ -2681 +2684 @@
             if (fEvents & VMMDEV_EVENT_MOUSE_POSITION_CHANGED)
             {
+                MouseNotifyCallback = pDevExt->MouseNotifyCallback;
                 fMousePositionChanged = true;
                 fEvents &= ~VMMDEV_EVENT_MOUSE_POSITION_CHANGED;
@@ -2760 +2764 @@
         VBoxGuestNativeISRMousePollEvent(pDevExt);
 #ifndef RT_OS_WINDOWS
-        if (pDevExt->MouseSetNotifyCallback.pfnNotify)
-            pDevExt->MouseSetNotifyCallback.pfnNotify(pDevExt->MouseSetNotifyCallback.pvNotify);
+        if (MouseNotifyCallback.pfnNotify)
+            MouseNotifyCallback.pfnNotify(MouseNotifyCallback.pvUser);
 #endif
     }

trunk/src/VBox/Additions/common/VBoxGuest/VBoxGuestInternal.h

@@ -167 +167 @@
      * together inside the session spinlock. */
     uint32_t volatile           fMouseStatus;
-    /** Callback and user data for a kernel mouse handler. */
-    VBoxGuestMouseSetNotifyCallback volatile MouseSetNotifyCallback;
     /** Counter of number of active ISRs.  Currently used for safely removing
      * the mouse handler callback. */
     uint32_t volatile           cISR;
+    /** Callback and user data for a kernel mouse handler. */
+    VBoxGuestMouseSetNotifyCallback MouseNotifyCallback;
 
     /** Windows part. */