Changeset 39815 in vbox

Timestamp:

Jan 20, 2012 9:32:29 AM (13 years ago)

Author:

vboxsync

Message:

crOpenGL: work around Ubuntu 11.04 FBO issues

Location:

trunk/src/VBox

Files:

• GuestHost/OpenGL/include/cr_glstate.h (modified) (1 diff)
• GuestHost/OpenGL/include/state/cr_framebuffer.h (modified) (1 diff)
• GuestHost/OpenGL/state_tracker/state_diff.c (modified) (1 diff)
• GuestHost/OpenGL/state_tracker/state_framebuffer.c (modified) (1 diff)
• HostServices/SharedOpenGL/crserverlib/server_context.c (modified) (3 diffs)
• HostServices/SharedOpenGL/unpacker/unpack.py (modified) (2 diffs)

trunk/src/VBox/GuestHost/OpenGL/include/cr_glstate.h

@@ -207 +207 @@
 DECLEXPORT(void) crStateDestroyContext(CRContext *ctx);
 
+CRContext * crStateSwichPrepare(CRContext *toCtx);
+void crStateSwichPostprocess(CRContext *fromCtx);
+
 DECLEXPORT(void) crStateFlushFunc( CRStateFlushFunc ff );
 DECLEXPORT(void) crStateFlushArg( void *arg );

trunk/src/VBox/GuestHost/OpenGL/include/state/cr_framebuffer.h

@@ -67 +67 @@
 DECLEXPORT(void) STATE_APIENTRY crStateFramebufferObjectDestroy(CRContext *ctx);
 DECLEXPORT(void) STATE_APIENTRY crStateFramebufferObjectSwitch(CRContext *from, CRContext *to);
+
+DECLEXPORT(void) STATE_APIENTRY crStateFramebufferObjectDisableHW(CRContext *ctx);
+DECLEXPORT(void) STATE_APIENTRY crStateFramebufferObjectReenableHW(CRContext *fromCtx, CRContext *toCtx);
+
 DECLEXPORT(GLuint) STATE_APIENTRY crStateGetFramebufferHWID(GLuint id);
 DECLEXPORT(GLuint) STATE_APIENTRY crStateGetRenderbufferHWID(GLuint id);

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_diff.c

@@ -345 +345 @@
 #endif
 }
+
+CRContext * crStateSwichPrepare(CRContext *toCtx)
+{
+    CRContext *fromCtx = GetCurrentContext();
+
+#ifdef CR_EXT_framebuffer_object
+    if (fromCtx)
+        crStateFramebufferObjectDisableHW(fromCtx);
+#endif
+
+    return fromCtx;
+}
+
+void crStateSwichPostprocess(CRContext *fromCtx)
+{
+    CRContext *toCtx = GetCurrentContext();;
+    if (!fromCtx || !toCtx)
+        return;
+
+#ifdef CR_EXT_framebuffer_object
+    crStateFramebufferObjectReenableHW(fromCtx, toCtx);
+#endif
+}

trunk/src/VBox/GuestHost/OpenGL/state_tracker/state_framebuffer.c

@@ -748 +748 @@
 }
 
+
+DECLEXPORT(void) STATE_APIENTRY
+crStateFramebufferObjectDisableHW(CRContext *ctx)
+{
+    if (ctx->framebufferobject.drawFB)
+        diff_api.BindFramebufferEXT(GL_DRAW_FRAMEBUFFER, 0);
+
+    if (ctx->framebufferobject.readFB)
+        diff_api.BindFramebufferEXT(GL_READ_FRAMEBUFFER, 0);
+
+    if (ctx->framebufferobject.drawFB)
+        diff_api.DrawBuffer(GL_BACK);
+    if (ctx->framebufferobject.readFB)
+        diff_api.ReadBuffer(GL_BACK);
+
+    if (ctx->framebufferobject.renderbuffer)
+        diff_api.BindRenderbufferEXT(GL_RENDERBUFFER_EXT, 0);
+}
+
+DECLEXPORT(void) STATE_APIENTRY
+crStateFramebufferObjectReenableHW(CRContext *fromCtx, CRContext *toCtx)
+{
+    GLboolean fAdjustDrawReadBuffers = GL_FALSE;
+
+    if (fromCtx->framebufferobject.drawFB
+            && fromCtx->framebufferobject.drawFB == toCtx->framebufferobject.drawFB)
+    {
+        diff_api.BindFramebufferEXT(GL_DRAW_FRAMEBUFFER, toCtx->framebufferobject.drawFB->hwid);
+        fAdjustDrawReadBuffers = GL_TRUE;
+    }
+
+    if (fromCtx->framebufferobject.readFB
+            && fromCtx->framebufferobject.readFB == toCtx->framebufferobject.readFB)
+    {
+        diff_api.BindFramebufferEXT(GL_READ_FRAMEBUFFER, toCtx->framebufferobject.readFB->hwid);
+        fAdjustDrawReadBuffers = GL_TRUE;
+    }
+
+    if (fAdjustDrawReadBuffers)
+    {
+        diff_api.DrawBuffer(toCtx->framebufferobject.drawFB?toCtx->framebufferobject.drawFB->drawbuffer[0]:toCtx->buffer.drawBuffer);
+        diff_api.ReadBuffer(toCtx->framebufferobject.readFB?toCtx->framebufferobject.readFB->readbuffer:toCtx->buffer.readBuffer);
+    }
+}
+
+
 DECLEXPORT(GLuint) STATE_APIENTRY crStateGetFramebufferHWID(GLuint id)
 {
     CRContext *g = GetCurrentContext();
     CRFramebufferObject *pFBO = (CRFramebufferObject*) crHashtableSearch(g->shared->fbTable, id);
-
+#ifdef DEBUG_misha
+    crDebug("FB id(%d) hw(%d)", id, pFBO ? pFBO->hwid : 0);
+#endif
     return pFBO ? pFBO->hwid : 0;
 }

trunk/src/VBox/HostServices/SharedOpenGL/crserverlib/server_context.c

@@ -231 +231 @@
 {
     CRMuralInfo *mural, *oldMural;
-    CRContext *ctx;
+    CRContext *ctx, *oldCtx;
 
     if (context >= 0 && window >= 0) {
@@ -267 +267 @@
         return;
     }
+
+    /* Ubuntu 11.04 hosts misbehave if context window switch is
+     * done with non-default framebuffer object settings.
+     * crStateSwichPrepare & crStateSwichPostprocess are supposed to work around this problem
+     * crStateSwichPrepare restores the FBO state to its default values before the context window switch,
+     * while crStateSwichPostprocess restores it back to the original values */
+    oldCtx = crStateSwichPrepare(ctx);
 
     /*
@@ -326 +333 @@
     crStateMakeCurrent( ctx );
 
+    crStateSwichPostprocess(oldCtx);
+
     if (oldMural != mural && crServerSupportRedirMuralFBO())
     {

trunk/src/VBox/HostServices/SharedOpenGL/unpacker/unpack.py

@@ -227 +227 @@
     for (i = 0 ; i < num_opcodes ; i++)
     {
+    
+        CRDBGPTR_CHECKZ(writeback_ptr);
+        CRDBGPTR_CHECKZ(return_ptr);
+    
         /*crDebug(\"Unpacking opcode \%d\", *unpack_opcodes);*/
         switch( *unpack_opcodes )
@@ -263 +267 @@
                 break;
         }
+        
+        CRDBGPTR_CHECKZ(writeback_ptr);
+        CRDBGPTR_CHECKZ(return_ptr);
+        
         unpack_opcodes--;
     }