Changeset 35458 in vbox

Timestamp:

Jan 10, 2011 2:15:07 PM (14 years ago)

Author:

vboxsync

Message:

Main/webservice: make global VirtualBox reference static to prevent unintentional unsynchronized accesses in the future, and add changelog for localhost fix

Location:

trunk

Files:

• doc/manual/user_ChangeLogImpl.xml (modified) (1 diff)
• src/VBox/Main/webservice/vboxweb.cpp (modified) (2 diffs)
• src/VBox/Main/webservice/vboxweb.h (modified) (1 diff)

trunk/doc/manual/user_ChangeLogImpl.xml

@@ -48 +48 @@
         <para>Main: fixed crash under rare circumstances due to an invalid
           logging string (4.0 regression)</para>
+      </listitem>
+
+      <listitem>
+        <para>Webservice: now listens to localhost by default as documented
+          (bug #6067)</para>
       </listitem>
 

trunk/src/VBox/Main/webservice/vboxweb.cpp

@@ -88 +88 @@
  ****************************************************************************/
 
-ComPtr<IVirtualBoxClient> g_pVirtualBoxClient = NULL;
-ComPtr<IVirtualBox>     g_pVirtualBox = NULL;
+static ComPtr<IVirtualBoxClient> g_pVirtualBoxClient = NULL;
 
 // generated strings in methodmaps.cpp
@@ -129 +128 @@
 util::WriteLockHandle  *g_pAuthLibLockHandle;
 
-// this mutex protects the global VirtualBox reference
-util::RWLockHandle  *g_pVirtualBoxLockHandle;
+// this mutex protects the global VirtualBox reference below
+static util::RWLockHandle *g_pVirtualBoxLockHandle;
+
+static ComPtr<IVirtualBox> g_pVirtualBox = NULL;
 
 // this mutex protects all of the below

trunk/src/VBox/Main/webservice/vboxweb.h

@@ -55 +55 @@
  ****************************************************************************/
 
-extern ComPtr<IVirtualBox> g_pVirtualBox;
 extern bool g_fVerbose;