Changeset 35129 in vbox

Timestamp:

Dec 15, 2010 1:10:12 PM (14 years ago)

Author:

vboxsync

Message:

GuestAdditionsUpdate/Main: Minor logging + waiting time adjustments.

File:

• trunk/src/VBox/Main/GuestImpl.cpp (modified) (6 diffs)

trunk/src/VBox/Main/GuestImpl.cpp

@@ -692 +692 @@
                                                     Bstr("").raw() /* Username */,
                                                     Bstr("").raw() /* Password */,
-                                                    5 * 1000 /* Wait 5s for getting the process started */,
+                                                    10 * 1000 /* Wait 10s for getting the process started */,
                                                     &uPID, progressInstaller.asOutParam(), &vrc);
                 if (SUCCEEDED(rc))
                 {
+                    LogRel(("Guest Additions update is running ...\n"));
+
                     /* If the caller does not want to wait for out guest update process to end,
                      * complete the progress object now so that the caller can do other work. */
@@ -703 +705 @@
                         aTask->progress->SetCurrentOperationProgress(70);
 
-                    LogRel(("Guest Additions update is running ...\n"));
+                    /* Wait until the Guest Additions installer finishes ... */
                     while (   SUCCEEDED(progressInstaller->COMGETTER(Completed(&fCompleted)))
                            && !fCompleted)
@@ -719 +721 @@
                             break;
                         }
-                        RTThreadSleep(1);
+                        RTThreadSleep(100);
                     }
 
@@ -737 +739 @@
                             else
                             {
+                                LogRel(("Guest Additions update failed (Exit code=%u, Status=%u, Flags=%u)\n",
+                                        uRetExitCode, uRetStatus, uRetFlags));
                                 rc = TaskGuest::setProgressErrorInfo(VBOX_E_IPRT_ERROR, aTask->progress,
                                                                      Guest::tr("Guest Additions update failed with exit code=%u (status=%u, flags=%u)"),
@@ -745 +749 @@
                                  && fCanceled)
                         {
+                            LogRel(("Guest Additions update was canceled\n"));
                             rc = TaskGuest::setProgressErrorInfo(VBOX_E_IPRT_ERROR, aTask->progress,
                                                                  Guest::tr("Guest Additions update was canceled by the guest with exit code=%u (status=%u, flags=%u)"),
@@ -751 +756 @@
                         else
                         {
-                            /* Guest Additions update was canceled by the user. */
+                            LogRel(("Guest Additions update was canceled by the user\n"));
                         }
                     }