Changeset 33910 in vbox

Timestamp:

Nov 9, 2010 3:45:44 PM (14 years ago)

Author:

vboxsync

Message:

Main, PXE: pass bus number too

Location:

trunk/src/VBox

Files:

• Devices/PC/DevPcBios.cpp (modified) (3 diffs)
• Main/ConsoleImpl2.cpp (modified) (4 diffs)

trunk/src/VBox/Devices/PC/DevPcBios.cpp

@@ -1099 +1099 @@
     {
         PCFGMNODE   pCfgNetBootDevice;
+        uint8_t     u8PciBus;
         uint8_t     u8PciDev;
         uint8_t     u8PciFn;
@@ -1109 +1110 @@
             szIndex[0] = '0' + i;
             pCfgNetBootDevice = CFGMR3GetChild(pCfgNetBoot, szIndex);
+
+            rc = CFGMR3QueryU8(pCfgNetBootDevice, "PCIBusNo", &u8PciBus);
+            if (rc == VERR_CFGM_VALUE_NOT_FOUND || rc == VERR_CFGM_NO_PARENT)
+            {
+                /* Do nothing and stop iterating. */
+                rc = VINF_SUCCESS;
+                break;
+            }
+            else if (RT_FAILURE(rc))
+                return PDMDEV_SET_ERROR(pDevIns, rc,
+                                        N_("Configuration error: Querying \"Netboot/x/PCIBusNo\" as integer failed"));
             rc = CFGMR3QueryU8(pCfgNetBootDevice, "PCIDeviceNo", &u8PciDev);
             if (rc == VERR_CFGM_VALUE_NOT_FOUND || rc == VERR_CFGM_NO_PARENT)
@@ -1129 +1141 @@
                 return PDMDEV_SET_ERROR(pDevIns, rc,
                                         N_("Configuration error: Querying \"Netboot/x/PCIFunctionNo\" as integer failed"));
+            /** @todo: encode bus number too */
             u16BusDevFn = ((u8PciDev & 0x1F) << 3) | (u8PciFn & 0x7);
             pThis->au16NetBootDev[i] = u16BusDevFn;

trunk/src/VBox/Main/ConsoleImpl2.cpp

@@ -209 +209 @@
 struct BootNic
 {
-    ULONG       mInstance;
-    unsigned    mPciDev;
-    unsigned    mPciFn;
-    ULONG       mBootPrio;
+    ULONG          mInstance;
+    PciBusAddress  mPciAddress;
+
+    ULONG          mBootPrio;
     bool operator < (const BootNic &rhs) const
     {
@@ -1583 +1583 @@
             BootNic     nic;
 
-            nic.mInstance = ulInstance;
-            nic.mPciDev   = iPciDeviceNo;
-            nic.mPciFn    = 0;
+            nic.mInstance    = ulInstance;
+            /* Could be updated by reference, if auto assigned */
+            nic.mPciAddress  = PciAddr;
 
             hrc = networkAdapter->COMGETTER(BootPriority)(&nic.mBootPrio);                  H();
@@ -1694 +1694 @@
                 InsertConfigNode(pNetBootCfg, achBootIdx, &pNetBtDevCfg);
                 InsertConfigInteger(pNetBtDevCfg, "NIC", it->mInstance);
-                InsertConfigInteger(pNetBtDevCfg, "PCIDeviceNo", it->mPciDev);
-                InsertConfigInteger(pNetBtDevCfg, "PCIFunctionNo", it->mPciFn);
+                InsertConfigInteger(pNetBtDevCfg, "PCIBusNo",      it->mPciAddress.iBus);
+                InsertConfigInteger(pNetBtDevCfg, "PCIDeviceNo",   it->mPciAddress.iDevice);
+                InsertConfigInteger(pNetBtDevCfg, "PCIFunctionNo", it->mPciAddress.iFn);
             }
         }
@@ -2277 +2278 @@
             {
                 BootNic aNic = llBootNics.front();
-                uint32_t u32NicPciAddr = (aNic.mPciDev << 16) | aNic.mPciFn;
+                uint32_t u32NicPciAddr = (aNic.mPciAddress.iDevice << 16) | aNic.mPciAddress.iFn;
                 InsertConfigInteger(pCfg, "NicPciAddress",    u32NicPciAddr);
             }