Changeset 32934 in vbox

Timestamp:

Oct 6, 2010 9:08:54 AM (14 years ago)

Author:

vboxsync

Message:

Main/Medium: Automatically repair streamOptimized VMDK files too. They are never created as diff images by normal VirtualBox operations, and forcing them to be base images allows importing OVF appliances created by broken VirtualBox versions.

File:

• trunk/src/VBox/Main/MediumImpl.cpp (modified) (1 diff)

trunk/src/VBox/Main/MediumImpl.cpp

@@ -3860 +3860 @@
                 ComAssertRCThrow(vrc, E_FAIL);
 
-                if (isImport)
+                /* streamOptimized VMDK images are only accepted as base
+                 * images, as this allows automatic repair of OVF appliances.
+                 * Since such images don't support random writes they will not
+                 * be created for diff images. Only an overly smart user might
+                 * manually create this case. Too bad for him. */
+                if (   isImport
+                    && !(uImageFlags & VD_VMDK_IMAGE_FLAGS_STREAM_OPTIMIZED))
                 {
                     /* the parent must be known to us. Note that we freely