Changeset 31388 in vbox

Timestamp:

Aug 5, 2010 10:26:18 AM (14 years ago)

Author:

vboxsync

Message:

Main: locking optimization

Location:

trunk/src/VBox/Main

Files:

• HostImpl.cpp (modified) (3 diffs)
• VirtualBoxImpl.cpp (modified) (3 diffs)

trunk/src/VBox/Main/HostImpl.cpp

@@ -529 +529 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    std::list <ComObjPtr<HostNetworkInterface> > list;
+    std::list<ComObjPtr<HostNetworkInterface> > list;
 
 # ifdef VBOX_WITH_HOSTNETIF_API
@@ -1481 +1481 @@
     AutoMultiWriteLock2 alock(this->lockHandle(), &m->usbListsLock COMMA_LOCKVAL_SRC_POS);
 
-
     for (settings::USBDeviceFiltersList::const_iterator it = data.llUSBDeviceFilters.begin();
          it != data.llUSBDeviceFilters.end();
@@ -1514 +1513 @@
     if (FAILED(autoCaller.rc())) return autoCaller.rc();
 
-    AutoReadLock alock1(this COMMA_LOCKVAL_SRC_POS);
-    AutoReadLock alock2(&m->usbListsLock COMMA_LOCKVAL_SRC_POS);
+    AutoReadLock alock(&m->usbListsLock COMMA_LOCKVAL_SRC_POS);
 
     data.llUSBDeviceFilters.clear();

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -3185 +3185 @@
     try
     {
-        // lock the lists while we're here
-        AutoReadLock machinesLock(m->allMachines.getLockHandle() COMMA_LOCKVAL_SRC_POS);
-
         // machines
         settings::MachinesRegistry machinesTemp;
         {
+            AutoReadLock machinesLock(m->allMachines.getLockHandle() COMMA_LOCKVAL_SRC_POS);
             for (MachinesOList::iterator it = m->allMachines.begin();
                  it != m->allMachines.end();
@@ -3274 +3272 @@
         }
 
+        mediaLock.release();
+
         settings::DHCPServersList dhcpServersTemp;
         {
@@ -3297 +3297 @@
         // leave extra data alone, it's still in the config file
 
-        /* host data (USB filters), will take host lock. */
-        {
-            mediaLock.release();
-            machinesLock.release();
-            rc = m->pHost->saveSettings(m->pMainConfigFile->host);
-            if (FAILED(rc)) throw rc;
-        }
+        // host data (USB filters)
+        rc = m->pHost->saveSettings(m->pMainConfigFile->host);
+        if (FAILED(rc)) throw rc;
 
         rc = m->pSystemProperties->saveSettings(m->pMainConfigFile->systemProperties);