Changeset 31242 in vbox

Timestamp:

Jul 30, 2010 1:06:39 PM (14 years ago)

Author:

vboxsync

Message:

Main: finish Machine::Unregister(), which can now recursively delete all snapshots and differencing media

Location:

trunk/src/VBox/Main

Files:

• MachineImpl.cpp (modified) (4 diffs)
• SnapshotImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/MachineImpl.cpp

@@ -4070 +4070 @@
     AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);
 
-    MediaList llMedia;
     if (mData->mSession.mState != SessionState_Unlocked)
         return setError(VBOX_E_INVALID_OBJECT_STATE,
                         tr("Cannot unregister the machine '%ls' while it is locked"),
-                           mUserData->mName.raw());
+                        mUserData->mName.raw());
 
     HRESULT rc = S_OK;
 
     // this list collects the files that should be reported
-    // as to be deleted to the caller in aFiles
+    // as to be deleted to the caller in aFiles (this includes the
+    // media files in llMedia below)
     std::list<Utf8Str> llFilesForCaller;
 
@@ -4096 +4096 @@
     }
 
-    size_t snapshotCount = 0;
+    size_t cSnapshots = 0;
     if (mData->mFirstSnapshot)
-        snapshotCount = mData->mFirstSnapshot->getAllChildrenCount() + 1;
-    if (snapshotCount)
-    {
-        if (fAutoCleanup)
-        {
-            // caller wants automatic detachment: then do that and report all media to the array
-
-            // Snapshot::beginDeletingSnapshot() needs the machine state to be this
-            MachineState_T oldState = mData->mMachineState;
-            mData->mMachineState = MachineState_DeletingSnapshot;
-
-            // make a copy of the first snapshot so the refcount does not drop to 0
-            // in beginDeletingSnapshot, which sets pFirstSnapshot to 0 (that hangs
-            // because of the AutoCaller voodoo)
-            ComObjPtr<Snapshot> pFirstSnapshot = mData->mFirstSnapshot;
-
-            // go!
-            pFirstSnapshot->uninitRecursively(alock, llMedia, llFilesForCaller);
-
-            mData->mMachineState = oldState;
-        }
-        else
-            return setError(VBOX_E_INVALID_OBJECT_STATE,
-                            tr("Cannot unregister the machine '%ls' because it has %d snapshots"),
-                            mUserData->mName.raw(), snapshotCount);
-    }
+        cSnapshots = mData->mFirstSnapshot->getAllChildrenCount() + 1;
+    if (cSnapshots && !fAutoCleanup)
+        // fail now before we start detaching media
+        return setError(VBOX_E_INVALID_OBJECT_STATE,
+                        tr("Cannot unregister the machine '%ls' because it has %d snapshots"),
+                           mUserData->mName.raw(), cSnapshots);
+
+    // this list collects the medium objects from all medium attachments
+    // which got detached from the machine and its snapshots, in the following
+    // order:
+    // 1) media from machine attachments (these have the "leaf" attachments with snapshots
+    //    and must be closed first, or closing the parents will fail because they will
+    //    children);
+    // 2) media from the youngest snapshots followed those from the parent snapshots until
+    //    the root ("first") snapshot of the machine
+    // This order allows for closing the media on this list from the beginning to the end
+    // without getting "media in use" errors.
+    MediaList llMedia;
 
     if (    !mMediaData.isNull()      // can be NULL if machine is inaccessible
@@ -4137 +4129 @@
                             mUserData->mName.raw(), mMediaData->mAttachments.size());
     }
+
+    if (cSnapshots)
+    {
+        // autoCleanup must be true here, or we would have failed above
+
+        // add the media from the medium attachments of the snapshots to llMedia
+        // as well, after the "main" machine media; Snapshot::uninitRecursively()
+        // calls Machine::detachAllMedia() for the snapshot machine, recursing
+        // into the children first
+
+        // Snapshot::beginDeletingSnapshot() asserts if the machine state is not this
+        MachineState_T oldState = mData->mMachineState;
+        mData->mMachineState = MachineState_DeletingSnapshot;
+
+        // make a copy of the first snapshot so the refcount does not drop to 0
+        // in beginDeletingSnapshot, which sets pFirstSnapshot to 0 (that hangs
+        // because of the AutoCaller voodoo)
+        ComObjPtr<Snapshot> pFirstSnapshot = mData->mFirstSnapshot;
+
+        // GO!
+        pFirstSnapshot->uninitRecursively(alock, llMedia, llFilesForCaller);
+
+        mData->mMachineState = oldState;
+    }
+
 
     if (FAILED(rc))
@@ -8721 +8738 @@
     ComObjPtr<Medium> oldmedium = pAttach->getMedium();
     DeviceType_T mediumType = pAttach->getType();
+
+    LogFlowThisFunc(("Entering, medium of attachment is %s\n", oldmedium ? oldmedium->getLocationFull().c_str() : "NULL"));
 
     if (pAttach->isImplicit())

trunk/src/VBox/Main/SnapshotImpl.cpp

@@ -839 +839 @@
     HRESULT rc = S_OK;
 
+    // make a copy of the Guid for logging before we uninit ourselfs
+#ifdef LOG_ENABLED
+    Guid uuid = getId();
+    Utf8Str name = getName();
+    LogFlowThisFunc(("Entering for snapshot '%s' {%RTuuid}\n", name.c_str(), uuid.raw()));
+#endif
+
     // recurse into children first so that the child media appear on
     // the list first; this way caller can close the media from the
@@ -869 +876 @@
     this->beginSnapshotDelete();
     this->uninit();
+
+#ifdef LOG_ENABLED
+    LogFlowThisFunc(("Leaving for snapshot '%s' {%RTuuid}\n", name.c_str(), uuid.raw()));
+#endif
 
     return S_OK;