Changeset 31034 in vbox

Timestamp:

Jul 23, 2010 7:22:44 AM (14 years ago)

Author:

vboxsync

Message:

Main, Python: session API changes, cleanup, tweaks

Location:

trunk/src/VBox

Files:

• Frontends/VBoxShell/vboxshell.py (modified) (1 diff)
• Main/EventImpl.cpp (modified) (1 diff)
• Main/VirtualBoxImpl.cpp (modified) (1 diff)
• Main/glue/vboxapi.py (modified) (1 diff)

trunk/src/VBox/Frontends/VBoxShell/vboxshell.py

@@ -491 +491 @@
         vb = ctx['vb']
         session = ctx['mgr'].getSessionObject(vb)
-        mach.lockForSession(session, True)
+        mach.lockMachine(session, ctx['global'].constants.LockType_Shared)
     except Exception,e:
         printErr(ctx, "Session to '%s' not open: %s" %(mach.name,str(e)))

trunk/src/VBox/Main/EventImpl.cpp

@@ -812 +812 @@
     ::RTCritSectEnter(&mcsQLock);
 
-    // If there was no events reading from the listener for the long time, 
-    // and events keep coming we shall unregister it.
-    if ((mQueue.size() > 200) && ((RTTimeMilliTS() - mLastRead) > 60 * 1000))
+    // If there was no events reading from the listener for the long time,
+    // and events keep coming, or queue is oversized we shall unregister this listener.
+    uint64_t sinceRead = RTTimeMilliTS() - mLastRead;
+    uint32_t queueSize = mQueue.size();
+    if ( (queueSize > 200) || ((queueSize > 100) && (sinceRead > 60 * 1000)))
     {
         ::RTCritSectLeave(&mcsQLock);

trunk/src/VBox/Main/VirtualBoxImpl.cpp

@@ -315 +315 @@
     const RTTHREAD                      threadAsyncEvent;
     EventQueue * const                  pAsyncEventQ;
-
-#ifdef RT_OS_WINDOWS
-    ComEventsHelper                     mComEvHelper;
-#endif
     const ComObjPtr<EventSource>        pEventSource;
 };

trunk/src/VBox/Main/glue/vboxapi.py

@@ -521 +521 @@
     def openMachineSession(self, mach, permitSharing = True):
          session = self.mgr.getSessionObject(self.vbox)
-         mach.lockForSession(session, permitSharing)
+         if permitSharing:
+             type = self.constants.LockType_Shared
+         else:
+             type = self.constants.LockType_Write
+         mach.lockMachine(session, type)
          return session