Changeset 30959 in vbox

Timestamp:

Jul 21, 2010 1:22:08 PM (14 years ago)

Author:

vboxsync

Message:

VbglR3ReportAdditionsStatus,VBoxGuestStatus: review of r63577. added two @todos.

Location:

trunk

Files:

• include/VBox/VMMDev.h (modified) (1 diff)
• src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibAdditions.cpp (modified) (2 diffs)

trunk/include/VBox/VMMDev.h

@@ -685 +685 @@
 typedef struct VBoxGuestStatus
 {
-    /** Facility the status is indicated for. */
+    /** Facility the status is indicated for.
+     * @todo Change to VBoxGuestStatusFacility. */
     uint32_t facility;
-    /** Current guest status. */
+    /** Current guest status.
+     * @todo Change to VBoxGuestStatusCurrent  */
     uint32_t status;
     /** Flags, not used. */

trunk/src/VBox/Additions/common/VBoxGuestLib/VBoxGuestR3LibAdditions.cpp

@@ -143 +143 @@
  *
  * @returns IPRT status value
- * @param uFacility
- * @param uStatus
- * @param uFlags
- */
-VBGLR3DECL(int) VbglR3ReportAdditionsStatus(VBoxGuestStatusFacility Facility, VBoxGuestStatusCurrent StatusCurrent, uint32_t uFlags)
+ * @param   enmFacility     The facility to report the status on.
+ * @param   enmStatus       The new status of the facility.
+ * @param   fReserved       Reserved for future use (what?).
+ */
+VBGLR3DECL(int) VbglR3ReportAdditionsStatus(VBoxGuestStatusFacility enmFacility,
+                                            VBoxGuestStatusCurrent enmStatusCurrent,
+                                            uint32_t fReserved)
 {
     VMMDevReportGuestStatus Report;
@@ -154 +156 @@
     if (RT_SUCCESS(rc))
     {
-
-        Report.guestStatus.facility = Facility;
-        Report.guestStatus.status = StatusCurrent;
-        Report.guestStatus.flags = uFlags;
+        Report.guestStatus.facility = enmFacility;
+        Report.guestStatus.status   = enmStatusCurrent;
+        Report.guestStatus.flags    = fReserved;
 
         rc = vbglR3GRPerform(&Report.header);