Changeset 30255 in vbox

Timestamp:

Jun 16, 2010 2:55:17 PM (14 years ago)

Author:

vboxsync

Message:

iprt/memcmp.asm: fixed wrongly returning 0 on 64-bit hosts if the bytes that differ are followed by the bytes that are the same.

Location:

trunk/src/VBox/Runtime

Files:

• common/string/memcmp.asm (modified) (1 diff)
• testcase/tstNoCrt-1.cpp (modified) (1 diff)

trunk/src/VBox/Runtime/common/string/memcmp.asm

@@ -105 +105 @@
     sub     rsi, 8
     sub     rdi, 8
+    repe cmpsb
 .not_equal_byte:
-    repe cmpsb
     mov     al, [xDI-1]
     movzx   ecx, byte [xSI-1]

trunk/src/VBox/Runtime/testcase/tstNoCrt-1.cpp

@@ -458 +458 @@
     iDiff = RT_NOCRT(memcmp)(s_szTest1, s_szTest3, sizeof(s_szTest1)); CHECK_DIFF( < );
     iDiff = RT_NOCRT(memcmp)(s_szTest3, s_szTest1, sizeof(s_szTest1)); CHECK_DIFF( > );
+    iDiff = RT_NOCRT(memcmp)("1234", "1a34", 4); CHECK_DIFF( < );
 
     RTPrintf("tstNoCrt-1: strcmp\n");