Changeset 29385 in vbox

Timestamp:

May 11, 2010 6:05:44 PM (14 years ago)

Author:

vboxsync

Message:

Main: cleaned up some pedantic warnings.

Location:

trunk/src/VBox/Main

Files:

• ConsoleVRDPServer.cpp (modified) (7 diffs)
• HostImpl.cpp (modified) (3 diffs)
• MachineImpl.cpp (modified) (3 diffs)
• include/ConsoleImpl.h (modified) (1 diff)
• include/MachineImpl.h (modified) (2 diffs)
• include/VirtualBoxBase.h (modified) (1 diff)
• xml/SchemaDefs.xsl (modified) (2 diffs)
• xml/Settings.cpp (modified) (1 diff)
• xpcom/server.cpp (modified) (1 diff)

trunk/src/VBox/Main/ConsoleVRDPServer.cpp

@@ -2230 +2230 @@
                                                                           \
         /* todo: Not sure if a AutoReadLock would be sufficient. */       \
-        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                                        \
+        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                  \
                                                                           \
         uint32_t value;                                                   \
@@ -2241 +2241 @@
                                                                           \
         return S_OK;                                                      \
-    }
+    }                                                                     \
+    extern void IMPL_GETTER_BOOL_DUMMY(void)
 
 #define IMPL_GETTER_SCALAR(_aType, _aName, _aIndex)                       \
@@ -2253 +2254 @@
                                                                           \
         /* todo: Not sure if a AutoReadLock would be sufficient. */       \
-        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                                        \
+        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                  \
                                                                           \
         _aType value;                                                     \
@@ -2264 +2265 @@
                                                                           \
         return S_OK;                                                      \
-    }
+    }                                                                     \
+    extern void IMPL_GETTER_SCALAR_DUMMY(void)
 
 #define IMPL_GETTER_BSTR(_aType, _aName, _aIndex)                         \
@@ -2276 +2278 @@
                                                                           \
         /* todo: Not sure if a AutoReadLock would be sufficient. */       \
-        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                                        \
+        AutoWriteLock alock(this COMMA_LOCKVAL_SRC_POS);                  \
                                                                           \
         uint32_t cbOut = 0;                                               \
@@ -2310 +2312 @@
                                                                           \
         return S_OK;                                                      \
-    }
+    }                                                                     \
+    extern void IMPL_GETTER_BSTR_DUMMY(void)
 
 IMPL_GETTER_BOOL   (BOOL,    Active,             VRDP_QI_ACTIVE);
@@ -2330 +2333 @@
 #undef IMPL_GETTER_BSTR
 #undef IMPL_GETTER_SCALAR
+#undef IMPL_GETTER_BOOL
 /* vi: set tabstop=4 shiftwidth=4 expandtab: */

trunk/src/VBox/Main/HostImpl.cpp

@@ -2317 +2317 @@
 
 #ifdef VBOX_WITH_RESOURCE_USAGE_API
+
 void Host::registerMetrics(PerformanceCollector *aCollector)
 {
@@ -2435 +2436 @@
     aCollector->registerMetric(new pm::Metric(ramUsage, ramVMMBallooned,
                                               new pm::AggregateMax()));
-};
+}
 
 void Host::unregisterMetrics (PerformanceCollector *aCollector)
@@ -2441 +2442 @@
     aCollector->unregisterMetricsFor(this);
     aCollector->unregisterBaseMetricsFor(this);
-};
+}
+
 #endif /* VBOX_WITH_RESOURCE_USAGE_API */
 

trunk/src/VBox/Main/MachineImpl.cpp

@@ -9137 +9137 @@
 
 #ifdef VBOX_WITH_RESOURCE_USAGE_API
+
 void Machine::registerMetrics(PerformanceCollector *aCollector, Machine *aMachine, RTPROCESS pid)
 {
@@ -9245 +9246 @@
     aCollector->registerMetric(new pm::Metric(guestCpuMem, guestPagedTotal, new pm::AggregateMin()));
     aCollector->registerMetric(new pm::Metric(guestCpuMem, guestPagedTotal, new pm::AggregateMax()));
-};
+}
 
 void Machine::unregisterMetrics(PerformanceCollector *aCollector, Machine *aMachine)
@@ -9254 +9255 @@
     if (mGuestHAL)
         delete mGuestHAL;
-};
+}
+
 #endif /* VBOX_WITH_RESOURCE_USAGE_API */
 

trunk/src/VBox/Main/include/ConsoleImpl.h

@@ -634 +634 @@
         iLedSas     = iLedScsi + cLedScsi,
         cLedSas     = 8,
-        cLedStorage = cLedFloppy + cLedIde + cLedSata + cLedScsi + cLedSas,
+        cLedStorage = cLedFloppy + cLedIde + cLedSata + cLedScsi + cLedSas
     };
     DeviceType_T maStorageDevType[cLedStorage];

trunk/src/VBox/Main/include/MachineImpl.h

@@ -1 +1 @@
 /* $Id$ */
-
 /** @file
- *
  * VirtualBox COM class implementation
  */
@@ -744 +742 @@
         SaveSTS_CurStateModified = 0x20,
         SaveSTS_StateFilePath = 0x40,
-        SaveSTS_StateTimeStamp = 0x80,
+        SaveSTS_StateTimeStamp = 0x80
     };
 

trunk/src/VBox/Main/include/VirtualBoxBase.h

@@ -427 +427 @@
  */
 #define DEFINE_EMPTY_CTOR_DTOR(cls) \
-    cls::cls () {}; cls::~cls () {};
+    cls::cls()  { /*empty*/ } \
+    cls::~cls() { /*empty*/ }
 
 ////////////////////////////////////////////////////////////////////////////////

trunk/src/VBox/Main/xml/SchemaDefs.xsl

@@ -102 +102 @@
   <xsl:apply-templates select="xsd:schema" mode="declare.enum"/>
 
-<xsl:text>    };
+<xsl:text>        DummyTerminator
+    };
 </xsl:text>
 
@@ -109 +110 @@
 <xsl:text>}
 
-#endif // ____H_SCHEMADEFS
+#endif // !____H_SCHEMADEFS
 </xsl:text>
 </xsl:template>

trunk/src/VBox/Main/xml/Settings.cpp

@@ -1633 +1633 @@
     ulIoCacheSize    = 5;
     ulIoBandwidthMax = 0;
-};
+}
 
 ////////////////////////////////////////////////////////////////////////////////

trunk/src/VBox/Main/xpcom/server.cpp

@@ -200 +200 @@
     /* Delay before shutting down the VirtualBox server after the last
      * VirtualBox instance is released, in ms */
-    VBoxSVC_ShutdownDelay = 5000,
+    VBoxSVC_ShutdownDelay = 5000
 };