Changeset 25035 in vbox

Timestamp:

Nov 27, 2009 1:51:42 AM (15 years ago)

Author:

vboxsync

Message:

Turns out the code workes fine because of the post increment in the erase(it++) invocation. Changed it to use the returned iterator like the rest of main does, just to be on the safe side.

File:

• trunk/src/VBox/Main/PerformanceImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/PerformanceImpl.cpp

@@ -494 +494 @@
         if ((*it)->associatedWith(aObject))
         {
-            /** @todo r=bird: This looks dodgy and needs to be tested with a VBOX_WITH_DEBUG_VCC_CRT. How to reproduce? */
             delete *it;
-            m.baseMetrics.erase(it++);
+            it = m.baseMetrics.erase(it);
         }
         else
@@ -516 +515 @@
         if ((*it)->associatedWith(aObject))
         {
-            /** @todo r=bird: This looks dodgy and needs to be tested with a VBOX_WITH_DEBUG_VCC_CRT. How to reproduce? */
             delete *it;
-            m.metrics.erase(it++);
+            it = m.metrics.erase(it);
         }
         else