Changeset 24711 in vbox

Timestamp:

Nov 17, 2009 10:28:24 AM (15 years ago)

Author:

vboxsync

Message:

Missing flushes + more stats

Location:

trunk/src/VBox/VMM

Files:

• PGM.cpp (modified) (1 diff)
• PGMInternal.h (modified) (1 diff)
• VMMAll/PGMAllHandler.cpp (modified) (3 diffs)
• VMMAll/PGMAllPhys.cpp (modified) (2 diffs)

trunk/src/VBox/VMM/PGM.cpp

@@ -1608 +1608 @@
     PGM_REG_COUNTER(&pPGM->StatR3PageMapTlbHits,              "/PGM/R3/Page/MapTlbHits",            "TLB hits.");
     PGM_REG_COUNTER(&pPGM->StatR3PageMapTlbMisses,            "/PGM/R3/Page/MapTlbMisses",          "TLB misses.");
+    PGM_REG_COUNTER(&pPGM->StatPageMapTlbFlushes,             "/PGM/R3/Page/MapTlbFlushes",         "TLB flushes (all contexts).");
 
     PGM_REG_PROFILE(&pPGM->StatRZSyncCR3HandlerVirtualUpdate, "/PGM/RZ/SyncCR3/Handlers/VirtualUpdate", "Profiling of the virtual handler updates.");

trunk/src/VBox/VMM/PGMInternal.h

@@ -2777 +2777 @@
     STAMCOUNTER StatRZPageMapTlbHits;               /**< RC/R0: Ring-3/0 page mapper TLB hits. */
     STAMCOUNTER StatRZPageMapTlbMisses;             /**< RC/R0: Ring-3/0 page mapper TLB misses. */
+    STAMCOUNTER StatPageMapTlbFlushes;              /**< ALL: Ring-3/0 page mapper TLB flushes. */
     STAMCOUNTER StatR3ChunkR3MapTlbHits;            /**< R3: Ring-3/0 chunk mapper TLB hits. */
     STAMCOUNTER StatR3ChunkR3MapTlbMisses;          /**< R3: Ring-3/0 chunk mapper TLB misses. */

trunk/src/VBox/VMM/VMMAll/PGMAllHandler.cpp

@@ -854 +854 @@
                 }
 
+                PGMPhysInvalidatePageMapTLB(pVM);
                 rc = VINF_SUCCESS;
                 break;
@@ -1042 +1043 @@
             PGM_PAGE_SET_PAGEID(pPage, PGM_PAGE_GET_PAGEID(pPageRemap));
             PGM_PAGE_SET_HNDL_PHYS_STATE(pPage, PGM_PAGE_HNDL_PHYS_STATE_DISABLED);
+            PGMPhysInvalidatePageMapTLB(pVM);
+
             LogFlow(("PGMHandlerPhysicalPageAlias: => %R[pgmpage]\n", pPage));
-
             pgmUnlock(pVM);
             return VINF_SUCCESS;
@@ -1142 +1144 @@
             PGM_PAGE_SET_PAGEID(pPage, NIL_GMM_PAGEID);
             PGM_PAGE_SET_HNDL_PHYS_STATE(pPage, PGM_PAGE_HNDL_PHYS_STATE_DISABLED);
+            PGMPhysInvalidatePageMapTLB(pVM);
             LogFlow(("PGMHandlerPhysicalPageAliasHC: => %R[pgmpage]\n", pPage));
             pgmUnlock(pVM);

trunk/src/VBox/VMM/VMMAll/PGMAllPhys.cpp

@@ -199 +199 @@
 {
     pgmLock(pVM);
+    STAM_COUNTER_INC(&pVM->pgm.s.StatPageMapTlbFlushes);
     for (unsigned i = 0; i < RT_ELEMENTS(pVM->pgm.s.PhysTlbHC.aEntries); i++)
     {
@@ -398 +399 @@
     PGM_PAGE_SET_PAGEID(pPage, pVM->pgm.s.aHandyPages[iHandyPage].idPage);
     PGM_PAGE_SET_STATE(pPage, PGM_PAGE_STATE_ALLOCATED);
+    PGMPhysInvalidatePageMapTLB(pVM);
 
     if (    fFlushTLBs