Changeset 23588 in vbox

Timestamp:

Oct 6, 2009 5:27:32 PM (15 years ago)

Author:

vboxsync

Message:

video 2d accel: display warning in VM display settings dialog when VRAM ammount is insufficient for 2D

Location:

trunk/src/VBox/Frontends/VirtualBox

Files:

trunk/src/VBox/Frontends/VirtualBox/include/VBoxFBOverlay.h

-              r23548
+              r23588
     static bool isAcceleration2DVideoAvailable();
+    /** additional video memory required for the best 2D support performance
+     *  total amount of VRAM required is thus calculated as requiredVideoMemory + required2DOffscreenVideoMemory  */
+    static quint64 required2DOffscreenVideoMemory();
     /* not supposed to be called by clients */
     int vhwaLoadExec(struct SSMHANDLE * pSSM, uint32_t u32Version);

-              r23438
+              r23588
 #ifdef VBOX_WITH_VIDEOHWACCEL
     static bool isAcceleration2DVideoAvailable();
+//    VBoxDefs::RenderMode vmAcceleration2DVideoRenderMode() {
+//#if 0
+//        return VBoxDefs::QGLOverlayMode;
+//#else
+//        return VBoxDefs::QGLMode;
+//#endif
+//        }
+    /** additional video memory required for the best 2D support performance
+     *  total amount of VRAM required is thus calculated as requiredVideoMemory + required2DOffscreenVideoMemory  */
+    static quint64 required2DOffscreenVideoMemory();
 #endif

-              r23579
+              r23588
+}
+/** additional video memory required for the best 2D support performance
+ *  total amount of VRAM required is thus calculated as requiredVideoMemory + required2DOffscreenVideoMemory  */
+/* static */
+quint64 VBoxQGLOverlay::required2DOffscreenVideoMemory()
+{
+    /* HDTV == 1920x1080 ~ 2M
+     * for the 4:2:2 formats each pixel is 2Bytes
+     * so each frame may be 4MB
+     * so for triple-buffering we would need 12 MB */
+    return _1M * 12;
+}
 VBoxVHWACommandElement * VBoxQGLOverlay::processCmdList(VBoxVHWACommandElement * pCmd)
+{

-              r23442
+              r23588
     return VBoxQGLOverlay::isAcceleration2DVideoAvailable();
+}
+/** additional video memory required for the best 2D support performance
+ *  total amount of VRAM required is thus calculated as requiredVideoMemory + required2DOffscreenVideoMemory  */
+/* static */
+quint64 VBoxGlobal::required2DOffscreenVideoMemory()
+{
+    return VBoxQGLOverlay::required2DOffscreenVideoMemory();
+}
 #endif

-              r22519
+              r23588
     connect (mCb3D, SIGNAL (stateChanged (int)),
              mValidator, SLOT (revalidate()));
+#ifdef VBOX_WITH_VIDEOHWACCEL
+    connect (mCb2DVideo, SIGNAL (stateChanged (int)),
+             mValidator, SLOT (revalidate()));
+#endif
     connect (mCbVRDP, SIGNAL (toggled (bool)),
              mValidator, SLOT (revalidate()));
 …
         return true;
+    }
+#ifdef VBOX_WITH_VIDEOHWACCEL
+    if (mCb2DVideo->isChecked())
+    {
+        quint64 needBytesWith2D = needBytes + VBoxGlobal::required2DOffscreenVideoMemory();
+        if ((quint64) mSlMemory->value() * _1M < needBytesWith2D)
+        {
+            aWarning = tr (
+                "you have assigned less than <b>%1</b> for video memory which is "
+                "the minimum amount required for the HD Video to be played efficiently.")
+                .arg (vboxGlobal().formatSize (needBytesWith2D, 0, VBoxDefs::FormatSize_RoundUp));
+            return true;
+        }
+    }
+#endif
     /* 3D Acceleration support test */

Note: See TracChangeset for help on using the changeset viewer.