Changeset 23543 in vbox

Timestamp:

Oct 4, 2009 9:24:12 PM (15 years ago)

Author:

vboxsync

Message:

PGMSavedState: Zero page counting (ram+mmio2).

File:

• trunk/src/VBox/VMM/PGMSavedState.cpp (modified) (11 diffs)

trunk/src/VBox/VMM/PGMSavedState.cpp

@@ -719 +719 @@
      * Special handling of zero pages.
      */
-    if (pLSPage->fZero)
+    bool const fZero = pLSPage->fZero;
+    if (fZero)
     {
         if (ASMMemIsZeroPage(pbPage))
@@ -771 +772 @@
         pVM->pgm.s.LiveSave.Mmio2.cReadyPages--;
         pVM->pgm.s.LiveSave.Mmio2.cDirtyPages++;
+        if (fZero)
+            pVM->pgm.s.LiveSave.Mmio2.cZeroPages--;
     }
     return true;
@@ -937 +940 @@
                 pVM->pgm.s.LiveSave.Mmio2.cDirtyPages--;
                 pVM->pgm.s.LiveSave.Mmio2.cReadyPages++;
+                if (u8Type == PGM_STATE_REC_MMIO2_ZERO)
+                    pVM->pgm.s.LiveSave.Mmio2.cZeroPages++;
                 iPageLast = iPage;
             }
@@ -1246 +1251 @@
                                     Assert(!paLSPages[iPage].fWriteMonitored);
                                     pVM->pgm.s.LiveSave.Ram.cMonitoredPages++;
-                                    if (paLSPages[iPage].fZero)
-                                        pVM->pgm.s.LiveSave.Ram.cZeroPages--;
                                 }
 
@@ -1253 +1256 @@
                                 {
                                     pVM->pgm.s.LiveSave.Ram.cReadyPages--;
+                                    if (paLSPages[iPage].fZero)
+                                        pVM->pgm.s.LiveSave.Ram.cZeroPages--;
                                     pVM->pgm.s.LiveSave.Ram.cDirtyPages++;
                                     if (++paLSPages[iPage].cDirtied > PGMLIVSAVEPAGE_MAX_DIRTIED)
@@ -1301 +1306 @@
                                 if (!paLSPages[iPage].fZero)
                                 {
-                                    paLSPages[iPage].fZero = 1;
-                                    paLSPages[iPage].fShared = 0;
-#ifdef PGMLIVESAVERAMPAGE_WITH_CRC32
-                                    paLSPages[iPage].u32Crc = PGM_STATE_CRC32_ZERO_PAGE;
-#endif
                                     if (!paLSPages[iPage].fDirty)
                                     {
@@ -1312 +1312 @@
                                         pVM->pgm.s.LiveSave.Ram.cDirtyPages++;
                                     }
-                                    pVM->pgm.s.LiveSave.Ram.cZeroPages++;
+                                    paLSPages[iPage].fZero = 1;
+                                    paLSPages[iPage].fShared = 0;
+#ifdef PGMLIVESAVERAMPAGE_WITH_CRC32
+                                    paLSPages[iPage].u32Crc = PGM_STATE_CRC32_ZERO_PAGE;
+#endif
                                 }
                                 break;
@@ -1319 +1323 @@
                                 if (!paLSPages[iPage].fShared)
                                 {
+                                    if (!paLSPages[iPage].fDirty)
+                                    {
+                                        paLSPages[iPage].fDirty = 1;
+                                        pVM->pgm.s.LiveSave.Ram.cReadyPages--;
+                                        if (paLSPages[iPage].fZero)
+                                            pVM->pgm.s.LiveSave.Ram.cZeroPages--;
+                                        pVM->pgm.s.LiveSave.Ram.cDirtyPages++;
+                                    }
                                     paLSPages[iPage].fZero = 0;
                                     paLSPages[iPage].fShared = 1;
@@ -1324 +1336 @@
                                     pgmR3StateCalcCrc32ForRamPage(pVM, pCur, paLSPages, iPage);
 #endif
-                                    if (!paLSPages[iPage].fDirty)
-                                    {
-                                        paLSPages[iPage].fDirty = 1;
-                                        pVM->pgm.s.LiveSave.Ram.cReadyPages--;
-                                        pVM->pgm.s.LiveSave.Ram.cDirtyPages++;
-                                    }
                                 }
                                 break;
@@ -1365 +1371 @@
                             pVM->pgm.s.LiveSave.Ram.cDirtyPages--;
                         else
+                        {
                             pVM->pgm.s.LiveSave.Ram.cReadyPages--;
+                            if (paLSPages[iPage].fZero)
+                                pVM->pgm.s.LiveSave.Ram.cZeroPages--;
+                        }
                         pVM->pgm.s.LiveSave.cIgnoredPages++;
                     }
@@ -1526 +1536 @@
                         paLSPages[iPage].fDirty = 0;
                         pVM->pgm.s.LiveSave.Ram.cReadyPages++;
-                        pVM->pgm.s.LiveSave.Ram.cDirtyPages--;
                         if (fZero)
                             pVM->pgm.s.LiveSave.Ram.cZeroPages++;
+                        pVM->pgm.s.LiveSave.Ram.cDirtyPages--;
                     }
                     if (idRamRangesGen != pVM->pgm.s.idRamRangesGen)