Changeset 22709 in vbox

Timestamp:

Sep 2, 2009 11:46:18 AM (15 years ago)

Author:

vboxsync

Message:

Also check for dirty pages

Location:

trunk/src/VBox/VMM

Files:

• PGMInternal.h (modified) (1 diff)
• PGMPhys.cpp (modified) (2 diffs)
• VMMAll/PGMAllPool.cpp (modified) (1 diff)

trunk/src/VBox/VMM/PGMInternal.h

@@ -3055 +3055 @@
 PPGMPOOLPAGE    pgmPoolGetPage(PPGMPOOL pPool, RTHCPHYS HCPhys);
 int             pgmPoolSyncCR3(PVMCPU pVCpu);
+bool            pgmPoolIsDirtyPage(PVM pVM, RTGCPHYS GCPhys);
 int             pgmPoolTrackFlushGCPhys(PVM pVM, PPGMPAGE pPhysPage, bool *pfFlushTLBs);
 uint16_t        pgmPoolTrackPhysExtAddref(PVM pVM, uint16_t u16, uint16_t iShwPT);

trunk/src/VBox/VMM/PGMPhys.cpp

@@ -375 +375 @@
         }
         else
-        if (PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage))
+        if (    PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage)
+#ifdef PGMPOOL_WITH_OPTIMIZED_DIRTY_PT
+            ||  pgmPoolIsDirtyPage(pVM, GCPhys)
+#endif
+           )
         {
             /* We *must* flush any corresponding pgm pool page here, otherwise we'll
@@ -445 +449 @@
              */
             if (    PGM_PAGE_HAS_ACTIVE_HANDLERS(pPage)
+#ifdef PGMPOOL_WITH_OPTIMIZED_DIRTY_PT
+                ||  pgmPoolIsDirtyPage(pVM, GCPhys)
+#endif
                 ||  RT_UNLIKELY(PGM_PAGE_GET_STATE(pPage) != PGM_PAGE_STATE_ALLOCATED))
             {

trunk/src/VBox/VMM/VMMAll/PGMAllPool.cpp

@@ -1609 +1609 @@
 
 /**
+ * Check if the specified page is dirty (not write monitored)
+ *
+ * @return dirty or not
+ * @param   pVM             VM Handle.
+ * @param   GCPhys          Guest physical address
+ */
+bool pgmPoolIsDirtyPage(PVM pVM, RTGCPHYS GCPhys)
+{
+    if (!pPool->cDirtyPages)
+        return false;
+
+    for (unsigned i = 0; i < RT_ELEMENTS(pPool->aIdxDirtyPages); i++)
+    {
+        if (pPool->aIdxDirtyPages[idxSlot] != NIL_PGMPOOL_IDX)
+        {
+            PPGMPOOLPAGE pPage;
+            unsigned     idxPage = pPool->aIdxDirtyPages[idxSlot];
+            AssertRelease(idxPage != NIL_PGMPOOL_IDX);
+
+            pPage = &pPool->aPages[idxPage];
+            if (pPage->GCPhys == GCPhys)
+                return true;
+        }
+    }
+    return false;
+}
+
+/**
  * Reset all dirty pages by reinstating page monitoring.
  *