Changeset 20889 in vbox

Timestamp:

Jun 24, 2009 12:06:59 PM (15 years ago)

Author:

vboxsync

Message:

PDM queue locking

File:

• trunk/src/VBox/VMM/PDMQueue.cpp (modified) (9 diffs)

trunk/src/VBox/VMM/PDMQueue.cpp

@@ -144 +144 @@
          * Insert into the queue list for timer driven queues.
          */
+        pdmLock(pVM);
         pQueue->pNext = pVM->pdm.s.pQueuesTimer;
         pVM->pdm.s.pQueuesTimer = pQueue;
+        pdmUnlock(pVM);
     }
     else
@@ -159 +161 @@
          *   problem any longer. The priority might be a nice feature for later though.
          */
+        pdmLock(pVM);
         if (!pVM->pdm.s.pQueuesForced)
             pVM->pdm.s.pQueuesForced = pQueue;
@@ -168 +171 @@
             pPrev->pNext = pQueue;
         }
+        pdmUnlock(pVM);
     }
 
@@ -387 +391 @@
     Assert(pQueue && pQueue->pVMR3);
     PVM pVM = pQueue->pVMR3;
-    VMCPU_ASSERT_EMT(&pVM->aCpus[0]);
+
+    pdmLock(pVM);
 
     /*
@@ -432 +437 @@
     pQueue->pNext = NULL;
     pQueue->pVMR3 = NULL;
+    pdmUnlock(pVM);
 
     /*
@@ -471 +477 @@
     if (!pDevIns)
         return VERR_INVALID_PARAMETER;
-    VMCPU_ASSERT_EMT(&pVM->aCpus[0]);
+
+    pdmLock(pVM);
 
     /*
@@ -499 +506 @@
     } while (pQueue);
 
+    pdmUnlock(pVM);
     return VINF_SUCCESS;
 }
@@ -520 +528 @@
     if (!pDrvIns)
         return VERR_INVALID_PARAMETER;
-    VMCPU_ASSERT_EMT(&pVM->aCpus[0]); /** @todo fix this using the "Misc" critical section. */
+
+    pdmLock(pVM);
 
     /*
@@ -548 +557 @@
     } while (pQueue);
 
+    pdmUnlock(pVM);
     return VINF_SUCCESS;
 }