Changeset 101612 in vbox

Timestamp:

Oct 27, 2023 8:18:57 AM (11 months ago)

Author:

vboxsync

Message:

tstRTArmv8: Check the full 32-bit range of masks. bugref:10371

File:

• trunk/src/VBox/Runtime/testcase/tstRTArmv8.cpp (modified) (4 diffs)

trunk/src/VBox/Runtime/testcase/tstRTArmv8.cpp

@@ -44 +44 @@
 #include <iprt/test.h>
 #include <iprt/stream.h>
+#include <iprt/sort.h>
 
 
@@ -62 +63 @@
 
 
+/** @callback_method_impl{FNRTSORTCMP}   */
+static DECLCALLBACK(int) cmpu32(void const *pvElement1, void const *pvElement2, void *pvUser)
+{
+    RT_NOREF(pvUser);
+    if (*(uint32_t const *)pvElement1 < *(uint32_t const *)pvElement2)
+        return -1;
+    if (*(uint32_t const *)pvElement1 > *(uint32_t const *)pvElement2)
+        return 1;
+    return 0;
+}
+
+
 void tstLogicalMask32(void)
 {
     RTTestISub("32-bit logical masks");
+    static uint32_t s_auValidMasks[1312];
+    unsigned        cValidMasks = 0;
 
     /* Test all legal combinations, both directions. */
@@ -80 +95 @@
                 uint32_t const uImmS = cOneBits | uImmSElmnLength;
                 uint32_t const uMask = Armv8A64ConvertImmRImmS2Mask32(uImmS, cRotations);
+                Assert(cValidMasks < RT_ELEMENTS(s_auValidMasks));
+                s_auValidMasks[cValidMasks++] = uMask;
 
                 if (g_cVerbosity > 1)
@@ -98 +115 @@
         uImmSElmnLength = (uImmSElmnLength << 1) & 0x3f;
     }
+
+    /* Now the other way around. */
+    RTSortShell(s_auValidMasks, cValidMasks, sizeof(s_auValidMasks[0]), cmpu32, NULL);
+    unsigned iValidMask     = 0;
+    uint32_t uNextValidMask = s_auValidMasks[iValidMask];
+    uint32_t uMask          = 0;
+    do
+    {
+        uint32_t uImmSRev = UINT32_MAX;
+        uint32_t uImmRRev = UINT32_MAX;
+        if (!Armv8A64ConvertMask32ToImmRImmS(uMask, &uImmSRev, &uImmRRev))
+        {
+            if (RT_LIKELY(uMask < uNextValidMask || iValidMask >= cValidMasks))
+            { }
+            else
+            {
+                RTTestIFailed("uMask=%#x - false negative\n", uMask);
+                break;
+            }
+        }
+        else if (RT_LIKELY(uMask == uNextValidMask && iValidMask < cValidMasks))
+        {
+            if (iValidMask + 1 < cValidMasks)
+                uNextValidMask = s_auValidMasks[++iValidMask];
+            else
+            {
+                iValidMask     = cValidMasks;
+                uNextValidMask = UINT32_MAX;
+            }
+        }
+        else
+        {
+            RTTestIFailed("uMask=%#x - false positive\n", uMask);
+            break;
+        }
+    } while (uMask++ < UINT32_MAX);
 }