Changeset 101317 in vbox

Timestamp:

Sep 29, 2023 3:07:45 PM (12 months ago)

Author:

vboxsync

Message:

Main/Unattended: Check for guest OS EFI requirement when preparing the Unattended Installer via Unattended::prepare() and refuse operation. Makes no sense yet to allow this, as EFI requires UDF remastering support for booting first. bugref:10516

File:

• trunk/src/VBox/Main/src-server/UnattendedImpl.cpp (modified) (2 diffs)

trunk/src/VBox/Main/src-server/UnattendedImpl.cpp

@@ -2615 +2615 @@
     VBOXOSTYPE const enmMachineOSType = idxMachineOSType < Global::cOSTypes
                                       ? Global::sOSTypes[idxMachineOSType].osType : VBOXOSTYPE_Unknown;
-
+    uint32_t const   osHint           = idxMachineOSType < Global::cOSTypes
+                                      ? Global::sOSTypes[idxMachineOSType].osHint : 0;
     /*
      * Check that the detected guest OS type for the ISO is compatible with
-     * that of the VM, boardly speaking.
+     * that of the VM, broadly speaking.
      */
     if (idxMachineOSType != idxIsoOSType)
@@ -2627 +2628 @@
                 || (enmMachineOSType & VBOXOSTYPE_ArchitectureMask) != VBOXOSTYPE_x64))
             return setError(E_FAIL, tr("The supplied ISO file is incompatible with the guest OS type of the VM: CPU architecture mismatch"));
-
-        /** @todo check BIOS/EFI requirement */
-    }
+    }
+
+    /* We don't support guest OSes w/ EFI, as that requires UDF remastering support we don't have yet. */
+    if (osHint & VBOXOSHINT_EFI)
+        return setError(E_FAIL, tr("The detected guest OS type requires EFI to boot and therefore is not supported yet"));
 
     /*