VirtualBox

Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#3304 closed defect (invalid)

reserved identifier violation

Reported by: Markus Elfring Owned by:
Component: other Version: VirtualBox 2.1.2
Keywords: Cc:
Guest type: other Host type: other

Description

I suggest to try the search pattern "_+[A-Z]+" on the source files. You will find a couple of places where project-specific names begin with several underscores.

Examples:


This does not fit to the expected naming conventions of the C language standard.

Change History (11)

comment:1 by Sander van Leeuwen, 15 years ago

Resolution: invalid
Status: newclosed

Could you please not open defects for such trivial things? Report them on the developer's mailinglist instead.

comment:2 by Markus Elfring, 15 years ago

Resolution: invalid
Status: closedreopened

I find it worth to mention also "trivial" issues about the source code here.

Some identifiers are reserved for the use in C/C++ compiler implementations.

I recommend to adjust include guards as a clean-up step.

comment:3 by Sander van Leeuwen, 15 years ago

Resolution: invalid
Status: reopenedclosed

I asked you politely not to use the bug tracker system for such purposes. Report to the dev list and don't argue here.

comment:4 by Markus Elfring, 15 years ago

Would you like to add any opinions or further details?

comment:6 by Markus Elfring, 15 years ago

Resolution: invalid
Status: closedreopened

I have got the impression from the response by Knut St. Osmundsen that symbols like "BEGIN_DECLS" and "END_DECLS" need further considerations.

comment:7 by Sander van Leeuwen, 15 years ago

Resolution: invalid
Status: reopenedclosed

It was discussed there, so no need to reopen.

comment:8 by Markus Elfring, 15 years ago

Will any further adjustments actions follow from this discussion?

comment:9 by Frank Mehnert, 15 years ago

The answer is: Yes, probably but most probably not within the next days /weeks. You might have noticed that we have more than 1400 bugs open. Some of them might be duplicates but there are still a lot of more important issues. And the last E-mail from Knut regarding this problem should be clear enough.

comment:10 by Markus Elfring, 15 years ago

Why do you want to keep this bug report closed when software developers and system testers will look at the involved details again in the future after issues with higher priority?

comment:11 by Markus Elfring, 15 years ago

I would appreciate if your last acknowledgement will also be indicated in the field "Resolution" of the tracking system.

Note: See TracTickets for help on using tickets.

© 2023 Oracle
ContactPrivacy policyTerms of Use