VirtualBox

Opened 10 years ago

Closed 10 years ago

#13265 closed defect (fixed)

vboxvideo does not behave well with drm_wait_vblank() -> fixed in 4.3 and later releases after 29 August 2014

Reported by: k-s Owned by:
Component: guest additions Version: VirtualBox 4.3.14
Keywords: Cc:
Guest type: Linux Host type: Mac OS X

Description

Using vboxvideo and the attached test case (which calls drm_wait_vblank()) triggers a kernel oops.

This happens with VirtualBox 4.3.14 official binary and extension pack (virtualbox.org) for MacOS 10.9.4 as host and ArchLinux 32bits kernel 3.15.8-1-ARCH + virtualbox-guest-modules 4.3.14-3.

It was found running Enlightenment from GIT that uses similar code path, but the attached test case is the minimum version.

Attachments (3)

vbox-vblank-crash.c (589 bytes ) - added by k-s 10 years ago.
vbox-vblank-crash.c
dmesg-3.15.8-1-ARCH_oops_vboxvideo_drm.log (30.8 KB ) - added by k-s 10 years ago.
dmesg log
oops-fedora-20-kernel-3.15.8-200.txt (2.7 KB ) - added by Ryback_ 10 years ago.

Download all attachments as: .zip

Change History (7)

by k-s, 10 years ago

Attachment: vbox-vblank-crash.c added

vbox-vblank-crash.c

by k-s, 10 years ago

dmesg log

comment:1 by Ryback_, 10 years ago

Also reproduces on Fedora 20, kernel 3.15.8-200.fc20.x86_64, SMP. Oops attached.

comment:2 by Michael Thayer, 10 years ago

Could you see if applying the following patch to the vboxvideo source (on your guest) and rebuilding it helps?

Index: vboxvideo_drm.c
===================================================================
--- vboxvideo_drm.c	(revision 95379)
+++ vboxvideo_drm.c	(working copy)
@@ -112,11 +112,7 @@
 
 int vboxvideo_driver_load(struct drm_device * dev, unsigned long flags)
 {
-# if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 28)
-    return drm_vblank_init(dev, 1);
-#else
     return 0;
-#endif
 }
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(3, 3, 0) || defined(DRM_FOPS_AS_POINTER)
 /* since linux-3.3.0-rc1 drm_driver::fops is pointer */

comment:3 by Michael Thayer, 10 years ago

Summary: vboxvideo does not behave well with drm_wait_vblank()vboxvideo does not behave well with drm_wait_vblank() -> fixed in 4.3 and later releases after 29 August 2014

No response, so I just committed the patch.

comment:4 by Frank Mehnert, 10 years ago

Resolution: fixed
Status: newclosed

Fix is part of VBox 4.3.16.

Note: See TracTickets for help on using tickets.

© 2023 Oracle
ContactPrivacy policyTerms of Use