VirtualBox

Ticket #1263 (closed defect: fixed)

Opened 9 months ago

Last modified 6 months ago

[PATCH] Linux kernel >= 2.6.25 no longer has change_page_attr => Fixed in 1.6

Reported by: hircus Assigned to:
Priority: major Component: other
Version: VirtualBox 1.5.6 Keywords: linux api-breakage
Cc: Guest type: other
Host type: other

Description

change_page_attr has been removed from the upcoming Linux kernel 2.6.25. The kernel version test currently conditionally compiles some change_page_attr workarounds for kernels >= 2.4.20; this now needs to be upper-bounded as well.

Patch attached, lightly tested (I tried booting DragonFly? BSD, and got to the boot menu, but then hit a known bug that DF BSD would freeze at the countdown screen)

Attachments

vbox-r7168-chpgattr-out.patch (1.4 kB) - added by hircus on 02/28/08 07:24:20.
Patch against vbox trunk (r7168)

Change History

02/28/08 07:24:20 changed by hircus

  • attachment vbox-r7168-chpgattr-out.patch added.

Patch against vbox trunk (r7168)

03/10/08 12:06:18 changed by frank

Hmm, you checked this on a x86 platform, right? Because on AMD64 changing of the page attributes should be necessary.

03/11/08 15:57:24 changed by hircus

No, this is on AMD64. The chage_page_attr function is simply not part of the 2.6.25 API at all -- there is a discussion in the LKML about this:

http://lkml.org/lkml/2008/2/17/319

03/25/08 18:05:59 changed by frank

Right, on lkml.org they write that some has to use set_memory_nx()/set_memory_x(). You cannot simply ignore these calls. The fix should be in SVN now.

04/07/08 09:53:34 changed by frank

  • summary changed from [PATCH] Linux kernel >= 2.6.25 no longer has change_page_attr to [PATCH] Linux kernel >= 2.6.25 no longer has change_page_attr => Fixed in 1.6.

05/06/08 09:00:25 changed by frank

  • status changed from new to closed.
  • resolution set to fixed.

© 2008 Sun Microsystems, Inc.
Contact – Privacy policy