<div dir="ltr"><div>Hi Michal, </div><div><br></div>Not to side track every one. Here is the output of lspci as listed by VM debugger <div><br></div><div><div>VBoxDbg> info phys</div><div>RAM ranges (pVM=00002aaab17d7000)</div><div>GC Phys Range pvHC </div><div>0000000000000000-000000009fffffff 0000000000000000 Base RAM</div><div>00000000b0000000-00000000b1ffffff 00002aaaba9ac000 VRam</div><div>00000000c0000000-00000000c001ffff 0000000000000000 E1000</div><div>00000000c0400000-00000000c07fffff 00002aaaba5a8000 VMMDev</div><div>00000000c0800000-00000000c0803fff 00002aaaba9a8000 VMMDev Heap</div><div>00000000c0804000-00000000c0804fff 0000000000000000 USB OHCI</div><div>00000000c8000000-00000000cbffffff 0000000000000000 ZebuPCIe</div><div>00000000cc000000-00000000cfffffff 0000000000000000 ZebuPCIe</div><div>00000000d0000000-00000000d01fffff 0000000000000000 ZebuPCIe</div><div>00000000d0200000-00000000d023ffff 0000000000000000 ZebuPCIe</div><div>00000000d0240000-00000000d0241fff 0000000000000000 AHCI</div><div>00000000fec00000-00000000fec00fff 0000000000000000 I/O APIC Memory</div><div>00000000fee00000-00000000fee00fff 0000000000000000 APIC Memory</div><div>00000000ffff0000-00000000ffffffff 0000000000000000 PC BIOS - 0xffffffff</div></div><div><br></div><div>apparently ICH9 never sees this passthrough device. "ZebuPCIe" device is my VGA device name.</div><div><br></div><div>Thanks.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 19, 2015 at 11:05 AM, Michal Necasek <span dir="ltr"><<a href="mailto:michal.necasek@oracle.com" target="_blank">michal.necasek@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:Times New Roman;font-size:12pt;color:#000000"><div><div style="font-family:Times New Roman;font-size:12pt;color:#000000"><br> Yes, I agree that this does not appear to be MSI related at all. I still don't quite understand the utility of working with old source code with known bugs. What's more, we can't fix old versions, and you'll almost certainly need either us to fix something or tell us what to fix it. But if you really want to start with an old version then that's of course your choice.<br><br> I saw two VGA devices listed in your lspci output. I'm not saying it has to cause problems, but it is an untried/untested configuration.<br><br> With EFI, you should expect the firmware to initialize the BARs. That is the significant difference compared to the "classic" BIOS in VirtualBox.<br><br> Comparing DevPciIch9.cpp with DevPCI.cpp is the right thing to do, although there are intentional differences. The problem is very likely there. I'd suggest tracing ich9pciUpdateMappings() as all BAR changes should go through there.<br><br> I can also tell you right away that I have no idea how well 64-bit BARs work because that's a feature more or less totally unused by the VirtualBox devices (it only comes into play with PCI passthrough, which is very rarely used). FYI, the device with most BARs (six) that we have is AHCI.<br><br> I'm afraid I don't have any more specific suggestions because I don't know what your code is doing. If you can distill the problem into a testcase that we can look at, we'd be happy to.<span class=""><br><br> Regards,<br> Michal<br><br>----- Original Message -----<br>From: <a href="mailto:apallapothu@gmail.com" target="_blank">apallapothu@gmail.com</a><br></span><div><div class="h5">To: <a href="mailto:michal.necasek@oracle.com" target="_blank">michal.necasek@oracle.com</a><br>Cc: <a href="mailto:vbox-dev@virtualbox.org" target="_blank">vbox-dev@virtualbox.org</a><br>Sent: Wednesday, August 19, 2015 2:46:55 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna<br>Subject: Re: [vbox-dev] ICH9 BAR5 access<br><br><div dir="ltr">Hi Michal, <div><br></div><div> I successfully used all BAR's with PIIX3 chipset. </div><div><br></div><div> Correct, MSI supporting is the piece forcing me move to ICH9. I understand changes have been made to MSI since then, but this particular issue doesn't seem to have anything to do with MSI, right? I was looking more interms of getting basic functionality of all BAR's on ICH9 working first before upgrading myself to latest VirtualBox. </div><div><br></div><div> My device is the VGA device. Did you find any duplicate mention somewhere ?</div><div><br></div><div> I will try with EFI, see if it makes any difference. What should I expect with this change ? Can you please recommend expected debug points in the source code that first invoke ICH9 BAR5 source code ? VBoxManage modifyvm --name VM_name ----firmware efi</div><div><br></div><div> I tried to compare basic function calls between ICH9 vs PIIX3, but eventually got lost at some point. Did find some similarities using gdb EM.cpp -> EMHM.cpp -> HM.cpp -> DevPciIch9.cpp / DevPCI.cpp.</div><div><br></div><div> Suggestions / recommendations would really help. </div><div><br></div><div>Thanks.</div><div><br></div><div><br></div><div><br></div><div><br></div><div> </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 19, 2015 at 7:51 AM, Michal Necasek <span dir="ltr"><<a href="mailto:michal.necasek@oracle.com" target="_blank">michal.necasek@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:Times New Roman;font-size:12pt;color:#000000"><div><div style="font-family:Times New Roman;font-size:12pt;color:#000000"><br> Hi Ananth,<br><br> PCIDevSetDWord in the device won't do it, that's expected. It will get rewritten.<br><br> I don't think VirtualBox supplies any device with so many BARs so it's entirely possible that something isn't working. The trouble is that you have your code + ours, and we only have our code, so it's quite hard for us to debug the problem.<br><br> One hint... what happens if you switch your VM to use EFI instead of the classic BIOS? I believe EFI should initialize all the PCI resources itself, so you might be able to see what happens even before an OS boots.<br><br> And two more comments. I see that you have both the VirtualBox VGA device and your own. No one can tell you for certain that that won't cause problems. And you presumably want to use MSIs (otherwise you wouldn't bother with ICH9), but you're using quite old version of VirtualBox. There were several fixes in the MSI handling area in VirtualBox 5.0.<br><br> Regards,<br> Michal<div><div><br><br>----- Original Message -----<br>From: <a href="mailto:apallapothu@gmail.com" target="_blank">apallapothu@gmail.com</a><br>To: <a href="mailto:klaus.espenlaub@oracle.com" target="_blank">klaus.espenlaub@oracle.com</a><br>Cc: <a href="mailto:vbox-dev@virtualbox.org" target="_blank">vbox-dev@virtualbox.org</a><br>Sent: Tuesday, August 18, 2015 9:04:05 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna<br>Subject: Re: [vbox-dev] ICH9 BAR5 access<br><br><div dir="ltr">Hi Klaus, <div><br></div><div> Thanks for the response. </div><div><br></div><div> In the PCIe config space I set all BAR's to 0, using PCIDevSetDWord .... no address mapping from myside. </div><div> I first register the region using PDMDevHlpPCIIORegionRegister with respective size.</div><div> BAR0 = 0x800,0000 128 M</div><div> BAR5 = 0x4,0000 256K</div><div> Then I register memory call backs using PDMDevHlpMMIORegister for the size.</div><div><br></div><div> While experimenting, I played with different base address in DevPciIch9.cpp "pGlobals->uPciBiosMmio = UINT32_C(0xB8000000);" which moved BAR's accordingly.</div><div><br></div><div> While experimenting, I have tried setting start address for BAR's in PCIe config space, I saw that this address eventually gets overwritten by FakeBIOS and then OS.</div><div> </div><div> When I ran lspci on the guest I did not see conflict in address mapping. Attached lspci output. My pass through device shows up under VGA. </div><div> I have added lspci output of fully functional PIIX3 chipset for comparison. </div><div><br></div><div> At the end of the attachment, please note the VM debugger output in ICH9 chip set which apparently doesn't see the VGA device. </div><div><br></div><div> Just to keep my message crisp, with the same device code, in PIIX3 I am able to see memory access to the addresses specified in BAR0, BAR5 while in ICH9, I only see access coming through in BAR0 and NOT BAR5. </div><div><br></div><div>Thanks.</div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 18, 2015 at 2:25 PM, Klaus Espenlaub <span dir="ltr"><<a href="mailto:klaus.espenlaub@oracle.com" target="_blank">klaus.espenlaub@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
Hi Ananth,<span><br>
<br>
<div>On 18.08.2015 20:04, Ananth Pallapothu
wrote:<br>
</div>
<blockquote>
<div dir="ltr">Hello Experts,
<div><br>
</div>
<div> <span style="font-family:Calibri;font-size:11pt">I have
added new
pass through device to the VirtualBox setup . Registered all
6 BAR's with
appropriate sizes, none exceeding 256M. All BAR's were set
to reflect hardware
functionality (assigned 0), eventually OS programmed base
address regions with
the sizes I have registered them with.</span></div>
</div>
</blockquote></span>
Can you provide more details (how you map the regions initially and
on remap)? Hard to say what's happening otherwise.<span><br>
<blockquote>
<div dir="ltr">
<p style="margin:0in;font-family:Calibri;font-size:11.0pt">My
fundamental
problem is, I have been able to access BAR0 and NOT BAR5. I
tried playing with
BIOSmmio address setting in DevPciIch9, that made difference
in relocating
BAR's but functionality remained the same (Not able to access
BAR5)</p>
<p style="margin:0in;font-family:Calibri;font-size:11.0pt">Interesting
part is,
PIIX3 chipset is fully functional ie., can access BAR5 in
PIIX3 but NOT in
ICH9. <br>
</p>
</div>
</blockquote></span>
Could be that with PIIX3 there's no remap and with ICH9 there's a
remap... really difficult to say anything with the sparse
information.<span><font color="#888888"><br>
<br>
Klaus</font></span><span><br>
<blockquote>
<div dir="ltr">
<p style="margin:0in;font-family:Calibri;font-size:11.0pt"><br>
</p>
<p style="margin:0in;font-family:Calibri;font-size:11.0pt">PS:
There seems to be some problem with my email ID, so not sure
whether my last email came through. Sorry if you have already
received it. </p>
<p style="margin:0in;font-family:Calibri;font-size:11.0pt"><br>
</p>
<p style="margin:0in;font-family:Calibri;font-size:11.0pt">Thanks.</p>
</div>
<br>
</blockquote>
</span></div>
<br>_______________________________________________<br>
vbox-dev mailing list<br>
<a href="mailto:vbox-dev@virtualbox.org" target="_blank">vbox-dev@virtualbox.org</a><br>
<a href="https://www.virtualbox.org/mailman/listinfo/vbox-dev" rel="noreferrer" target="_blank">https://www.virtualbox.org/mailman/listinfo/vbox-dev</a><br>
<br></blockquote></div><br></div>
</div></div></div></div></div></div></blockquote></div><br></div>
</div></div></div></div></div></div></blockquote></div><br></div>