<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Alexander,<br>
<br>
this one definitely looks correct, and I believe that your guess is
ultimately correct (even though I don't think the code intentionally
preserved the no longer needed lock)... will go into the code ASAP.<br>
<br>
Klaus<br>
<br>
<div class="moz-cite-prefix">On 30.01.2015 15:53, <a class="moz-txt-link-abbreviated" href="mailto:a.urakov@drweb.com">a.urakov@drweb.com</a>
wrote:<br>
</div>
<blockquote cite="mid:54CB9B05.6050507@drweb.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
Hello!<br>
<br>
We would like to contribute to VirtualBox under MIT license. We
send our changes to fix bug described at <a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://www.virtualbox.org/ticket/13801">https://www.virtualbox.org/ticket/13801</a>
.<br>
<br>
The idea is that there is no need to hold write lock on parent
medium to change its locking type. In current version we unlock
all session locked list first and only then we update locking
type. But in this case only element of <i>pMediumLockList</i> is
changed, not <i>Medium</i> object. May be parent write-locking
code left after old version, where parent lock type updating
looked like this (version <i>3.1.8</i>):<br>
<br>
<font face="monospace">ComObjPtr<Medium> parent =
pMedium->getParent();<br>
/* make the relock atomic */<br>
AutoWriteLock parentLock (parent);<br>
rc = parent->UnlockWrite(NULL);<br>
AssertComRC(rc);<br>
rc = parent->LockRead(NULL);<br>
AssertComRC(rc);</font><br>
<br>
Regards,<br>
Alexander<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
vbox-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:vbox-dev@virtualbox.org">vbox-dev@virtualbox.org</a>
<a class="moz-txt-link-freetext" href="https://www.virtualbox.org/mailman/listinfo/vbox-dev">https://www.virtualbox.org/mailman/listinfo/vbox-dev</a>
</pre>
</blockquote>
<br>
<div class="moz-signature">-- <br>
<a href="http://www.oracle.com" target="_blank"><img
src="cid:part2.09010705.01090708@oracle.com" alt="Oracle"
border="0" height="26" width="114"></a><br>
<font color="#666666" face="Verdana, Arial, Helvetica, sans-serif"
size="2">Klaus Espenlaub | Software Development Director<br>
Phone: <a href="tel:+49%207151%2060405205"
moz-do-not-send="true">+49 7151 60405205</a> <br>
<font color="#ff0000">Oracle</font> VM VirtualBox<br>
<br>
ORACLE Deutschland B.V. & Co. KG | Werkstr. 24 | 71384
Weinstadt</font><br>
<br>
<font color="#666666" face="Verdana, Arial, Helvetica, sans-serif"
size="1">ORACLE Deutschland B.V. & Co. KG<br>
Hauptverwaltung: Riesstr. 25, D-80992 München<br>
Registergericht: Amtsgericht München, HRA 95603<br>
Geschäftsführer: Jürgen Kunz<br>
<br>
Komplementärin: ORACLE Deutschland Verwaltung B.V.<br>
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande<br>
Handelsregister der Handelskammer Midden-Niederlande, Nr.
30143697<br>
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher<br>
</font>
<br>
<a href="http://www.oracle.com/commitment" target="_blank"><img
src="cid:part5.03070204.02020602@oracle.com" alt="Green
Oracle" align="absmiddle" border="0" height="28" width="44"></a>
<font color="#4B7D42" face="Verdana, Arial, Helvetica, sans-serif"
size="1">Oracle is committed to developing practices and
products that help protect the environment</font>
<!-- This signature was generated by the MyDesktop Oracle Business Signature utility version 4.2 -->
</div>
</body>
</html>