<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hi Ed,</div><div><br></div><div>thanks for the patch, applied to the internal svn. Should be visible in the public one soon.</div><div><br></div><div>Regards,</div><div>Alexander Eichner</div><br><div><div>On 24.09.2012 22:35, Ed Maste wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>It appears that some build infrastructure refactoring was done, but not<br>applied to the FreeBSD port. SVN r10662 added SUPDRV_WITH_RELEASE_LOGGER<br>to src/VBox/HostDrivers/Support/Makefile.kmk but not the Makefile that<br>is actually used by the FreeBSD build.<br><br>Also delete a log message attempted after the logging subsystem is<br>destroyed, and change RTR0Term to RTR0TermForced in the unload function<br>based on what I saw in the Linux driver.<br>---<br>This patch is against FreeBSD's 4.2.0 port.<br><br> src/VBox/HostDrivers/Support/freebsd/Makefile | 2 +-<br> src/VBox/HostDrivers/Support/freebsd/SUPDrv-freebsd.c | 4 +---<br> 2 files changed, 2 insertions(+), 4 deletions(-)<br><br>diff --git a/src/VBox/HostDrivers/Support/freebsd/Makefile b/src/VBox/HostDrivers/Support/freebsd/Makefile<br>index 970ccb2..f116793 100644<br>--- a/src/VBox/HostDrivers/Support/freebsd/Makefile<br>+++ b/src/VBox/HostDrivers/Support/freebsd/Makefile<br>@@ -27,7 +27,7 @@<br><br> KMOD = vboxdrv<br><br>-CFLAGS += -DRT_OS_FREEBSD -DIN_RING0 -DIN_RT_R0 -DIN_SUP_R0 -DVBOX -DRT_WITH_VBOX -Iinclude -I. -Ir0drv -w -DVBOX_WITH_HARDENING -DVBOX_WITH_64_BITS_GUESTS -DDEBUG<br>+CFLAGS += -DRT_OS_FREEBSD -DIN_RING0 -DIN_RT_R0 -DIN_SUP_R0 -DSUPDRV_WITH_RELEASE_LOGGER -DVBOX -DRT_WITH_VBOX -Iinclude -I. -Ir0drv -w -DVBOX_WITH_HARDENING -DVBOX_WITH_64_BITS_GUESTS -DDEBUG<br><br> .if (${MACHINE_ARCH} == "i386")<br> CFLAGS += -DRT_ARCH_X86<br>diff --git a/src/VBox/HostDrivers/Support/freebsd/SUPDrv-freebsd.c b/src/VBox/HostDrivers/Support/freebsd/SUPDrv-freebsd.c<br>index bbc8b49..03df09e 100644<br>--- a/src/VBox/HostDrivers/Support/freebsd/SUPDrv-freebsd.c<br>+++ b/src/VBox/HostDrivers/Support/freebsd/SUPDrv-freebsd.c<br>@@ -195,11 +195,9 @@ static int VBoxDrvFreeBSDUnload(void)<br><br> supdrvDeleteDevExt(&g_VBoxDrvFreeBSDDevExt);<br><br>- RTR0Term();<br>+ RTR0TermForced();<br><br> memset(&g_VBoxDrvFreeBSDDevExt, 0, sizeof(g_VBoxDrvFreeBSDDevExt));<br>-<br>- Log(("VBoxDrvFreeBSDUnload: returns\n"));<br> return VINF_SUCCESS;<br> }<br><br>-- <br>1.7.11.5<br><br>_______________________________________________<br>vbox-dev mailing list<br><a href="mailto:vbox-dev@virtualbox.org">vbox-dev@virtualbox.org</a><br><a href="https://www.virtualbox.org/mailman/listinfo/vbox-dev">https://www.virtualbox.org/mailman/listinfo/vbox-dev</a><br></div></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">ORACLE Deutschland B.V. & Co. KG Alexander Eichner<br>Werkstrasse 24 Engineer, VirtualBox<br>71384 Weinstadt, Germany <a href="mailto:frank.mehnert@oracle.com">mailto:alexander.eichner@oracle.com</a><br><br>Hauptverwaltung: Riesstr. 25, D-80992 München<br>Registergericht: Amtsgericht München, HRA 95603</div><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Geschäftsführer: Jürgen Kunz<br><br>Komplementärin: ORACLE Deutschland Verwaltung B.V.<br>Rijnzathe 6, 3454PV De Meern, Niederlande<br>Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697<br>Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher</div></span></span>
</div>
<br></body></html>