<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
<font face="Verdana">Well thinking that it was some left over src
code I purged the build environment and rebuilt using 1) the
latest from SVN and then 2) with you latest patch. Neither seemed
to make a difference. </font>I will see if I can tweak it some
more tomorrow and let you know but I suspect the negations are
causing the problem,especially since I can put them back and all is
happy again. Seems something else is looking for these removed
snippets somewhere and are not at all happy that they are missing.<br>
<br>
Oh happy days, right :-)<br>
<br>
<br>
<br>
On 03/23/2011 04:58 PM, Michael Thayer wrote:
<blockquote
cite="mid:1300917519.2461.15.camel@michael-latitude-e6410"
type="cite">
<pre wrap="">On Wed, 2011-03-23 at 16:52 -0500, Perry Halbert wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Sorry that doesn't get it either.
I read that link a few days ago but remember I had no problems until
the
changes in 36350 today.
</pre>
</blockquote>
<pre wrap="">I take it it builds correctly for you this time though. Did you check
whether the device nodes are correctly created under /dev/vboxusb when
you plug in devices? And you might also check which of the two entries
which I removed from that structure was the important one. I presume it
was
{ "/dev/bus/usb", true }
Regards,
Michael
</pre>
<blockquote type="cite">
<pre wrap="">On 03/23/2011 04:34 PM, Michael Thayer wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Wed, 2011-03-23 at 16:15 -0500, Perry Halbert wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Well going back to the present build does not work. Node is not
created
and and the error returns.
I added the changes that you show in previous reply and get an
</pre>
</blockquote>
</blockquote>
<pre wrap="">error
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">shown below
</pre>
</blockquote>
<pre wrap="">Sorry about that! Here is the correct patch.
By the way, see also [ <a class="moz-txt-link-freetext" href="http://www.virtualbox.org/ticket/8502">http://www.virtualbox.org/ticket/8502</a> ].
Regards,
Michael
Index: src/VBox/Main/src-server/linux/USBGetDevices.cpp
===================================================================
--- src/VBox/Main/src-server/linux/USBGetDevices.cpp (revision
</pre>
</blockquote>
<pre wrap="">70699)
</pre>
<blockquote type="cite">
<pre wrap="">+++ src/VBox/Main/src-server/linux/USBGetDevices.cpp (working copy)
@@ -1442,17 +1442,7 @@
if ( fHaveInotify
&& !pcBestSysfs
&&
</pre>
</blockquote>
<pre wrap="">RTPathExists(s_aTreeLocations[i].szDevicesRoot))
</pre>
<blockquote type="cite">
<pre wrap="">- {
- PUSBDEVICE pDevices;
-
- pDevices =
</pre>
</blockquote>
<pre wrap="">getDevicesFromSysfs(s_aTreeLocations[i].szDevicesRoot,
</pre>
<blockquote type="cite">
<pre wrap="">- true);
- if (pDevices)
- {
- pcBestSysfs =&s_aTreeLocations[i];
- deviceListFree(&pDevices);
- }
- }
+ pcBestSysfs =&s_aTreeLocations[i];
}
if (pcBestUsbfs&& !fPreferSysfs)
return pcBestUsbfs;
</pre>
<blockquote type="cite">
<pre wrap="">Reverting and nodes do show up in /dev/vboxusb
This works
static const USBDEVTREELOCATION s_aTreeLocations[] =
{
{ "/proc/bus/usb", false },
{ "/dev/bus/usb", false },
{ "/dev/vboxusb", true },
{ "/dev/bus/usb", true },
};
This does not work
static const USBDEVTREELOCATION s_aTreeLocations[] =
{
{ "/dev/vboxusb", true },
{ "/proc/bus/usb", false },
};
On 03/23/2011 03:30 PM, Michael Thayer wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Wed, 2011-03-23 at 15:17 -0500, Perry Halbert wrote:
</pre>
<blockquote type="cite">
<pre wrap="">By additions this time I was talking about the additional changes
</pre>
</blockquote>
</blockquote>
<pre wrap="">to
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">the
file.
Give me a bit and I will see what happens. Takes about 10
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">minutes
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">to
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">get back to a clean build.
</pre>
</blockquote>
<pre wrap="">If that makes a difference you might try with the following patch.
Regards,
Michael
Index: src/VBox/Main/src-server/linux/USBGetDevices.cpp
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">===================================================================
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">--- src/VBox/Main/src-server/linux/USBGetDevices.cpp (revision
</pre>
</blockquote>
<pre wrap="">70699)
</pre>
<blockquote type="cite">
<pre wrap="">+++ src/VBox/Main/src-server/linux/USBGetDevices.cpp (working
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">copy)
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">@@ -1443,15 +1443,8 @@
&& !pcBestSysfs
&&
</pre>
</blockquote>
<pre wrap="">RTPathExists(s_aTreeLocations[i].szDevicesRoot))
</pre>
<blockquote type="cite">
<pre wrap=""> {
- PUSBDEVICE pDevices;
-
- pDevices =
</pre>
</blockquote>
<pre wrap="">getDevicesFromSysfs(s_aTreeLocations[i].szDevicesRoot,
</pre>
<blockquote type="cite">
<pre wrap="">- true);
- if (pDevices)
- {
- pcBestSysfs =&s_aTreeLocations[i];
- deviceListFree(&pDevices);
- }
+ pcBestSysfs =&s_aTreeLocations[i];
+ deviceListFree(&pDevices);
}
}
if (pcBestUsbfs&& !fPreferSysfs)
</pre>
<blockquote type="cite">
<pre wrap="">On 03/23/2011 03:14 PM, Michael Thayer wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Wed, 2011-03-23 at 15:06 -0500, Perry Halbert wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Yes it had the directory. I don't know if it actually created
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">it
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">but
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">when investigating it was there.
I can rebuild with the additions if you want for me to look for
anything
specific.
</pre>
</blockquote>
<pre wrap="">The Additions shouldn't play any part here. I will give you
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">another
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">test though - try stopping all VirtualBox processes, plugging in
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">a
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">USB
</pre>
<blockquote type="cite">
<pre wrap="">device (a node should be created in /dev/vboxusb for it) and
</pre>
</blockquote>
<pre wrap="">restarting
</pre>
<blockquote type="cite">
<pre wrap="">VirtualBox.
Regards,
Michael
</pre>
<blockquote type="cite">
<pre wrap="">On 03/23/2011 02:58 PM, Michael Thayer wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hello Perry,
On Wed, 2011-03-23 at 14:52 -0500, Perry Halbert wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Changeset 36350 breaks the USB subset
trunk/src/VBox/Main/src-server/linux/USBGetDevices.cpp
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">(modified)
</pre>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">(1 diff)
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">Host Ubuntu 10.10 x86_32
Removing the change fixes it.
</pre>
</blockquote>
<pre wrap="">Does the directory /dev/vboxusb exist on your system? Does
</pre>
</blockquote>
</blockquote>
</blockquote>
<pre wrap="">creating
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">it
</pre>
<blockquote type="cite">
<pre wrap="">make a difference if not?
Regards,
Michael
</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>