<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Johannes Rudolph wrote:
<blockquote
cite="mid:984cd2110905040804h1be5a98fpdce144466618230a@mail.gmail.com"
type="cite">
<div>Hi Sander,<br>
</div>
<div>looking at your points i have some questions:</div>
<div><em>>2) </em><em>multiple snapshots, discard last snapshot
is indeed a merge with its
parent (diff images merged; parent saved state deleted)</em></div>
<div>how can parent have a saved state? I always thought saved
states do only occur in the deepest level of the snapshot tree?</div>
</blockquote>
A snapshot is by definition a saved state plus a set of differencing
disk images (which can be empty if no disks are attached to the VM).<br>
<br>
<blockquote
cite="mid:984cd2110905040804h1be5a98fpdce144466618230a@mail.gmail.com"
type="cite">
<div><em></em></div>
<div><em>>3) multiple snapshots, discard other (non-last) snapshot
merges the
image diff with its child and deletes the saved state </em><br>
</div>
<div>which saved state is deleted? It makes sense the image is merged
with the child. Based on this i would rather suggest changing
description in UI to something like:</div>
<div>"Merge Snapshot into Snapshot-Tree" and in the tooltip: "If the
Snapshot is at the deepest level of the snapshot tree it is merged with
its parent, else with its child snaphot"</div>
</blockquote>
The merge only takes place on the implementation level, because of the
diff. disk dependencies. From the user's perspective the snapshot was
deleted. There is no need to inform the user about technical details as
that will only lead to confusion.<br>
<br>
Regards,<br>
<br>
Sander<br>
<br>
<blockquote
cite="mid:984cd2110905040804h1be5a98fpdce144466618230a@mail.gmail.com"
type="cite">
<div>Does that make sense?</div>
<div>Kind Regards,</div>
<div>Johannes Rudolph</div>
<div class="gmail_quote">On Mon, May 4, 2009 at 12:05 PM, Sander van
Leeuwen <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:Sander.Vanleeuwen@sun.com">Sander.Vanleeuwen@sun.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000">
Hi Johannes,<br>
<br>
Your proposal is not completely correct either. Consider the following
cases:<br>
1) one snapshot, discard is indeed a merge of the diff image with its
parent (main disk image)<br>
2) multiple snapshots, discard last snapshot is indeed a merge with its
parent (diff images merged; parent saved state deleted)<br>
3) multiple snapshots, discard other (non-last) snapshot merges the
image diff with its child and deletes the saved state<br>
<br>
So basically the button and popup menu items should change description
according to the highlighted snapshot. (1 & 2 merge, 3 remains
discard)<br>
<br>
Regards,<br>
<br>
Sander<br>
<br>
Johannes Rudolph wrote:
<blockquote type="cite">
<div>
<div class="h5"><span class="gmail_quote"><span><span
class="gmail_quote"><br>
</span>Hi all,<br>
<br>
This is my first contribution to VirtualBox, so please be so kind to
notice me if im doing something horribly wrong :-)<br>
<br>
I think button naming in QT GUI for the Snapshot functionality is
confusing.<br>
"Discard Snapshot" <i>is </i>discarding the Snapshot, however it does
so by <i>merging </i>it with the parent. This behaviour
clearly is not described in the current description. As also suggested
in this blog post<br>
<a moz-do-not-send="true"
href="http://srackham.wordpress.com/cloning-and-copying-virtualbox-virtual-machines/"
target="_blank">http://srackham.wordpress.com/cloning-and-copying-virtualbox-virtual-machines/<br>
</a>i therefore renamed the button to "Merge with Parent".<br>
<br>
See also: <a moz-do-not-send="true"
href="http://www.virtualbox.org/ticket/1101" target="_blank">Bug #1101</a>
<br>
Just to further underline my point that the current button naming is
causing unnescessary confusion.<br>
<br>
I also adapted the German translation accordingly, as its my native
language.<br>
<br>
It would also be nescessary to introduce a new button icon for this,
however i'd first like to ask if this patch is likely to be approved.
Im afraid i couldnt submit a correct svn patch, but i do currently do
not have access to a subversion installation. The two files attached
reside in:<br>
trunk/src/VBox/Frontends/VirtualBox/nls/<br>
trunk/src/VBox/Frontends/VirtualBox/src/<br>
<br>
respectively.<br>
<br>
Everything i submitted is subject to MIT License.<br>
<br>
Would someone please be so kind to provide some feedback about my
suggestion?<br>
<br>
Kind Regards,<br>
<span>Johannes Rudolph<br>
</span><br clear="all">
</span></span><br clear="all">
</div>
</div>
<pre><hr size="4" width="90%">
_______________________________________________
vbox-dev mailing list
<a moz-do-not-send="true" href="mailto:vbox-dev@virtualbox.org"
target="_blank">vbox-dev@virtualbox.org</a>
<a moz-do-not-send="true"
href="http://vbox.innotek.de/mailman/listinfo/vbox-dev" target="_blank">http://vbox.innotek.de/mailman/listinfo/vbox-dev</a>
</pre>
</blockquote>
<br>
<br>
<pre cols="72">--
Kind regards / Mit freundlichen Gruessen / Met vriendelijke groet
--
Sun Microsystems GmbH Sander van Leeuwen
Werkstrasse 24 Senior Staff Engineer, VirtualBox
71384 Weinstadt, Germany <a moz-do-not-send="true"
href="mailto:Sander.Vanleeuwen@sun.com" target="_blank">mailto:Sander.Vanleeuwen@sun.com</a>
================================================
Sitz der Gesellschaft: Sun Microsystems GmbH,
Sonnenallee 1, 85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder,
Wolfgang Engels, Dr. Roland Boehmer
Vorsitzender des Aufsichtsrates: Martin Haering
================================================</pre>
</div>
</blockquote>
</div>
<br>
<div><br>
</div>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Kind regards / Mit freundlichen Gruessen / Met vriendelijke groet
--
Sun Microsystems GmbH Sander van Leeuwen
Werkstrasse 24 Senior Staff Engineer, VirtualBox
71384 Weinstadt, Germany <a class="moz-txt-link-freetext" href="mailto:Sander.Vanleeuwen@sun.com">mailto:Sander.Vanleeuwen@sun.com</a>
================================================
Sitz der Gesellschaft: Sun Microsystems GmbH,
Sonnenallee 1, 85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder,
Wolfgang Engels, Dr. Roland Boehmer
Vorsitzender des Aufsichtsrates: Martin Haering
================================================</pre>
</body>
</html>