<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi Johannes,<br>
<br>
Your proposal is not completely correct either. Consider the following
cases:<br>
1) one snapshot, discard is indeed a merge of the diff image with its
parent (main disk image)<br>
2) multiple snapshots, discard last snapshot is indeed a merge with its
parent (diff images merged; parent saved state deleted)<br>
3) multiple snapshots, discard other (non-last) snapshot merges the
image diff with its child and deletes the saved state<br>
<br>
So basically the button and popup menu items should change description
according to the highlighted snapshot. (1 & 2 merge, 3 remains
discard)<br>
<br>
Regards,<br>
<br>
Sander<br>
<br>
Johannes Rudolph wrote:
<blockquote
cite="mid:984cd2110905032317h530c9a2dmd94396d77b98fdb5@mail.gmail.com"
type="cite"><span class="gmail_quote"><span class="e"
id="q_121016125502f21b_0"><span class="gmail_quote"><br>
</span>Hi all,<br>
<br>
This is my first contribution to VirtualBox, so please be so kind to
notice me if im doing something horribly wrong :-)<br>
<br>
I think button naming in QT GUI for the Snapshot functionality is
confusing.<br>
"Discard Snapshot" <i>is </i>discarding the Snapshot, however it does
so by <i>merging </i>it with the parent. This behaviour
clearly is not described in the current description. As also suggested
in this blog post<br>
<a moz-do-not-send="true"
href="http://srackham.wordpress.com/cloning-and-copying-virtualbox-virtual-machines/"
target="_blank" onclick="return top.js.OpenExtLink(window,event,this)">http://srackham.wordpress.com/cloning-and-copying-virtualbox-virtual-machines/<br>
</a>i therefore renamed the button to "Merge with Parent".<br>
<br>
See also: <a moz-do-not-send="true"
href="http://www.virtualbox.org/ticket/1101">Bug #1101</a> <br>
Just to further underline my point that the current button naming is
causing unnescessary confusion.<br>
<br>
I also adapted the German translation accordingly, as its my native
language.<br>
<br>
It would also be nescessary to introduce a new button icon for this,
however i'd first like to ask if this patch is likely to be approved.
Im afraid i couldnt submit a correct svn patch, but i do currently do
not have access to a subversion installation. The two files attached
reside in:<br>
trunk/src/VBox/Frontends/VirtualBox/nls/<br>
trunk/src/VBox/Frontends/VirtualBox/src/<br>
<br>
respectively.<br>
<br>
Everything i submitted is subject to MIT License.<br>
<br>
Would someone please be so kind to provide some feedback about my
suggestion?<br>
<br>
Kind Regards,<br>
<span>Johannes Rudolph<br>
</span><br clear="all">
</span></span><br clear="all">
<pre wrap="">
<hr size="4" width="90%">
_______________________________________________
vbox-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:vbox-dev@virtualbox.org">vbox-dev@virtualbox.org</a>
<a class="moz-txt-link-freetext" href="http://vbox.innotek.de/mailman/listinfo/vbox-dev">http://vbox.innotek.de/mailman/listinfo/vbox-dev</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Kind regards / Mit freundlichen Gruessen / Met vriendelijke groet
--
Sun Microsystems GmbH Sander van Leeuwen
Werkstrasse 24 Senior Staff Engineer, VirtualBox
71384 Weinstadt, Germany <a class="moz-txt-link-freetext" href="mailto:Sander.Vanleeuwen@sun.com">mailto:Sander.Vanleeuwen@sun.com</a>
================================================
Sitz der Gesellschaft: Sun Microsystems GmbH,
Sonnenallee 1, 85551 Kirchheim-Heimstetten
Amtsgericht Muenchen: HRB 161028
Geschaeftsfuehrer: Thomas Schroeder,
Wolfgang Engels, Dr. Roland Boehmer
Vorsitzender des Aufsichtsrates: Martin Haering
================================================</pre>
</body>
</html>