Changeset 4564

Timestamp:

09/06/07 13:11:56 (1 year ago)

Author:

vboxsync

Message:

Don't allow gc to hc virt address conversions from non-EMT threads.

Files:

• trunk/src/VBox/VMM/PDMDevice.cpp (modified) (3 diffs)

trunk/src/VBox/VMM/PDMDevice.cpp

@@ -3266 +3266 @@
-             pDevIns->pDevReg->szDeviceName, pDevIns->iInstance, GCPhys, cbRange, ppvHC));
-
+    if (!VM_IS_EMT(pDevIns->Internal.s.pVMHC))
+        return VERR_ACCESS_DENIED;
+
-    int rc = PGMPhysGCPhys2HCPtr(pDevIns->Internal.s.pVMHC, GCPhys, cbRange, ppvHC);
-
@@ -3283 +3286 @@
-             pDevIns->pDevReg->szDeviceName, pDevIns->iInstance, GCPtr, pHCPtr));
-
+    if (!VM_IS_EMT(pDevIns->Internal.s.pVMHC))
+        return VERR_ACCESS_DENIED;
+
-    int rc = PGMPhysGCPtr2HCPtr(pVM, GCPtr, pHCPtr);
-
@@ -3298 +3304 @@
-    LogFlow(("pdmR3DevHlp_PhysGCPtr2GCPhys: caller='%s'/%d: GCPtr=%VGv pGCPhys=%p\n",
-             pDevIns->pDevReg->szDeviceName, pDevIns->iInstance, GCPtr, pGCPhys));
+
+    if (!VM_IS_EMT(pDevIns->Internal.s.pVMHC))
+        return VERR_ACCESS_DENIED;
-
-    int rc = PGMPhysGCPtr2GCPhys(pVM, GCPtr, pGCPhys);