Changeset 2672

Timestamp:

05/16/07 17:31:49 (2 years ago)

Author:

vboxsync

Message:

Main: Ported latest dmik/exp branch changes (r21219:21226) into the trunk.

Files:

• trunk/include/VBox/com/ErrorInfo.h (modified) (9 diffs)
• trunk/include/VBox/com/com.h (modified) (1 diff)
• trunk/src/VBox/Main/ConsoleImpl.cpp (modified) (7 diffs)
• trunk/src/VBox/Main/MachineImpl.cpp (modified) (7 diffs)
• trunk/src/VBox/Main/VirtualBoxBase.cpp (modified) (3 diffs)
• trunk/src/VBox/Main/VirtualBoxErrorInfoImpl.cpp (modified) (4 diffs)
• trunk/src/VBox/Main/glue/ErrorInfo.cpp (modified) (9 diffs)
• trunk/src/VBox/Main/glue/com.cpp (modified) (6 diffs)
• trunk/src/VBox/Main/idl/VirtualBox.xidl (modified) (1 diff)
• trunk/src/VBox/Main/include/VirtualBoxBase.h (modified) (8 diffs)
• trunk/src/VBox/Main/include/VirtualBoxErrorInfoImpl.h (modified) (3 diffs)

trunk/include/VBox/com/ErrorInfo.h

@@ -28 +28 @@
-#include "VBox/com/Guid.h"
-#include "VBox/com/assert.h"
+
+#include <iprt/memory> // for auto_copy_ptr
-
-struct IProgress;
@@ -102 +104 @@
-     *  pointer available.
-     */
-
-
-
+
+
+
+
-
-    /**
@@ -118 +121 @@
-     *              error
-     */
-
-
-
+
+
+
+
-
-    /**
@@ -129 +133 @@
-     *              an error
-     */
-
-
-
+
+
+
+
-
-    /** Specialization for the IVirtualBoxErrorInfo smart pointer */
-
-
-
+
+
+
+
-
-    /**
@@ -146 +152 @@
-     *                  holds error info to be fetched by this instance
-     */
-
-
-
-
-
+
+
+
+
+
+
-
-    /**
@@ -201 +208 @@
-
-    /**
+     *  Returns the next error information object or @c NULL if there is none.
+     */
+    const ErrorInfo *getNext() const { return mNext.get(); }
+
+    /**
-     *  Returns the name of the interface that defined the error
-     */
@@ -233 +245 @@
-protected:
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-
-    HRESULT mResultCode;
@@ -251 +262 @@
-    Bstr mText;
-
+    cppx::auto_copy_ptr <ErrorInfo> mNext;
+
-    Bstr mInterfaceName;
-    Guid mCalleeIID;
-    Bstr mCalleeName;
+
+    ComPtr <IUnknown> mErrorInfo;
-};
-
-/**
-,
+
- *  pointer, reads its errorInfo attribute and uses the returned
- *  IVirtualBoxErrorInfo instance to construct itself.
@@ -277 +292 @@
-};
-
+/**
+ *  A convenience subclass of ErrorInfo that allows to preserve the current
+ *  error info. Instances of this class fetch an error info object set on the
+ *  current thread and keep a reference to it, which allows to restore it
+ *  later using the #restore() method. This is useful to preserve error
+ *  information returned by some method for the duration of making another COM
+ *  call that may set its own error info and overwrite the existing
+ *  one. Preserving and restoring error information makes sense when some
+ *  method wants to return error information set by other call as its own
+ *  error information while it still needs to make another call before return.
+ *
+ *  The usage pattern is:
+ *  <code>
+ *      rc = foo->method();
+ *      if (FAILED (rc))
+ *      {
+ *           ErrorInfoKeeper eik;
+ *           ...
+ *           // bar may return error info as well
+ *           bar->method();
+ *           ...
+ *           // restore error info from foo to return it to the caller
+ *           eik.restore();
+ *           return rc;
+ *      }
+ *  </code>
+ */
+class ErrorInfoKeeper : public ErrorInfo
+{
+public:
+
+    /** Constructs a new instance that will fetch the current error info. */
+    ErrorInfoKeeper() : ErrorInfo (false), mForgot (false)
+        { init (true /* aKeepObj */); }
+
+    /**
+     *  Destroys this instance and automatically calls #restore() which will
+     *  either restorr error info fetched by the constructor or do nothing
+     *  if #forget() was called before destruction. */
+    ~ErrorInfoKeeper() { if (!mForgot) restore(); }
+
+    /**
+     *  Restores error info fetched by the constructor and forgets it
+     *  afterwards.
+     *
+     *  @return COM result of the restore operation.
+     */
+    HRESULT restore();
+
+    /**
+     *  Forgets error info fetched by the constructor which prevents it from
+     *  being restored by #restore() or by the destructor.
+     */
+    void forget() { mForgot = 0; }
+
+private:
+
+    bool mForgot : 1;
+};
+
-}; // namespace com
-

trunk/include/VBox/com/com.h

@@ -38 +38 @@
-
-/**
-downs
+s down
- *  Must be called on every thread before termination.
-any 
+
- */
-void Shutdown();
+
+/**
+ *  Resolves a given interface ID to a string containing the interface name.
+ *  If, for some reason, the given IID cannot be resolved to a name, a NULL
+ *  string is returned. A non-NULL string returned by this funciton must be
+ *  freed using SysFreeString().
+ *
+ *  @param aIID     ID of the interface to get a name for
+ *  @param aName    Resolved interface name or @c NULL on error
+ */
+void GetInterfaceNameByIID (const GUID &aIID, BSTR *aName);
-
-}; // namespace com

trunk/src/VBox/Main/ConsoleImpl.cpp

@@ -1785 +1785 @@
-    if (FAILED (rc) && !taskCreationFailed)
-    {
-fetch any
- ei
+preserve
+Keeper eik
-
-        if (beganSavingState)
@@ -1807 +1807 @@
-        else
-            setMachineStateLocally (lastMachineState);
-
-        /* restore fetched error info */
-        setError (ei);
-    }
-
@@ -2340 +2337 @@
-    if (FAILED (rc) && !taskCreationFailed)
-    {
-fetch any
- ei
+preserve
+Keeper eik
-
-        if (beganTakingSnapshot && takingSnapshotOnline)
@@ -2363 +2360 @@
-        else
-            setMachineStateLocally (lastMachineState);
-
-        /* restore fetched error info */
-        setError (ei);
-    }
-
@@ -6795 +6789 @@
-            if (FAILED (hrc) || VBOX_FAILURE (vrc))
-            {
-the current
- ei
+existing
+Keeper eik
-
-                /*
@@ -6804 +6798 @@
-                HRESULT hrc2 = console->powerDown();
-                AssertComRC (hrc2);
-
-                setError (ei);
-            }
-        }
@@ -6860 +6852 @@
-         */
-
-the current
- ei
+existing
+Keeper eik
-
-        Assert (console->mpVM == NULL);
-        vmstateChangeCallback (NULL, VMSTATE_TERMINATED, VMSTATE_CREATING,
-                               console);
-        setError (ei);
-    }
-

trunk/src/VBox/Main/MachineImpl.cpp

@@ -8951 +8951 @@
-        }
-
-fetch the current
- mergeEi
+preserve existing
+Keeper mergeEik
-        HRESULT mergeRc = rc;
-
@@ -9026 +9026 @@
-        while (0);
-
-
+
+
-        if (FAILED (mergeRc))
-        {
-            rc = mergeRc;
-            setError (mergeEi);
-        }
-    }
-    while (0);
@@ -9039 +9037 @@
-        if (!aTask.subTask)
-        {
-save current
- ei
+preserve existing
+Keeper eik
-
-            /* restore the machine state */
@@ -9055 +9053 @@
-                              true /* aInformCallbacksAnyway */);
-            }
-
-            /* restore current error info */
-            setError (ei);
-        }
-
@@ -9187 +9182 @@
-            {
-                /* here we can still safely rollback, so do it */
-
+
+
-                /* undo all changes */
-                rollback (false /* aNotify */);
-                setError (ei);
-                break;
-            }
@@ -9306 +9301 @@
-    if (FAILED (rc))
-    {
-
+
+
-
-        if (!stateRestored)
@@ -9328 +9324 @@
-                saveSettings();
-        }
-
-        setError (ei);
-    }
-

trunk/src/VBox/Main/VirtualBoxBase.cpp

@@ -641 +641 @@
-////////////////////////////////////////////////////////////////////////////////
-
+/**
+ *  Sets error info for the current thread. This is an internal function that
+ *  gets eventually called by all public variants.  If @a aPreserve is
+ *  @c true, then the current error info object set on the thread before this
+ *  method is called will be preserved in the IVirtualBoxErrorInfo::next
+ *  attribute of the new error info object that will be then set as the
+ *  current error info object.
+ */
-// static
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
-
-    /* these are mandatory, others -- not */
- (FAILED (resultCode)
- (!text.isEmpty()
-
-    return E_FAIL
-
-ComObjPtr <VirtualBoxErrorInfo> info;
-HRESULT rc = info.createObject();
-if (SUCCEEDED (rc))
-{
-info->init (resultCode, iid, component, text
+Return (FAILED (aResultCode), E_FAIL
+Return (!aText.isEmpty(), E_FAIL
+
+HRESULT rc = S_OK
+
+do
+{
+    ComObjPtr <VirtualBoxErrorInfo> info;
+    rc = info.createObject();
+CheckComRCBreakRC (rc
-
-#if defined (__WIN__)
+
+        ComPtr <IVirtualBoxErrorInfo> curInfo;
+        if (aPreserve)
+        {
+            /* get the current error info if any */
+            ComPtr <IErrorInfo> err;
+            rc = ::GetErrorInfo (0, err.asOutParam());
+            CheckComRCBreakRC (rc);
+            rc = err.queryInterfaceTo (curInfo.asOutParam());
+            if (FAILED (rc))
+            {
+                /* create a IVirtualBoxErrorInfo wrapper for the native
+                 * IErrorInfo object */
+                ComObjPtr <VirtualBoxErrorInfo> wrapper;
+                rc = wrapper.createObject();
+                if (SUCCEEDED (rc))
+                {
+                    rc = wrapper->init (err);
+                    if (SUCCEEDED (rc))
+                        curInfo = wrapper;
+                }
+            }
+        }
+        /* On failure, curInfo will stay null */
+        Assert (SUCCEEDED (rc) || curInfo.isNull());
+
+        /* set the current error info and preserve the previous one if any */
+        rc = info->init (aResultCode, aIID, aComponent, aText, curInfo);
+        CheckComRCBreakRC (rc);
-
-        ComPtr <IErrorInfo> err;
@@ -677 +715 @@
-            nsCOMPtr <nsIExceptionManager> em;
-            rc = es->GetCurrentExceptionManager (getter_AddRefs (em));
-
+
+
+
+
-            {
+                /* get the current error info if any */
-                ComPtr <nsIException> ex;
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-            }
+            /* On failure, curInfo will stay null */
+            Assert (SUCCEEDED (rc) || curInfo.isNull());
+
+            /* set the current error info and preserve the previous one if any */
+            rc = info->init (aResultCode, aIID, aComponent, aText, curInfo);
+            CheckComRCBreakRC (rc);
+
+            ComPtr <nsIException> ex;
+            rc = info.queryInterfaceTo (ex.asOutParam());
+            if (SUCCEEDED (rc))
+                rc = em->SetCurrentException (ex);
-        }
-        else if (rc == NS_ERROR_UNEXPECTED)
@@ -705 +771 @@
-#endif // !defined (__WIN__)
-    }
+    while (0);
-
-    AssertComRC (rc);
-
-
-
-
-
-
-
-
-
-
-
-
+
-}
-

trunk/src/VBox/Main/VirtualBoxErrorInfoImpl.cpp

@@ -26 +26 @@
-////////////////////////////////////////////////////////////////////////////////
-
-void
-
-
+HRESULT
+   
+   
-{
-    mResultCode = aResultCode;
@@ -35 +35 @@
-    mText = aText;
-    mNext = aNext;
+
+    return S_OK;
-}
-
@@ -87 +89 @@
-#if defined (__WIN__)
-
+/**
+ *  Initializes itself by fetching error information from the given error info
+ *  object.
+ */
+HRESULT VirtualBoxErrorInfo::init (IErrorInfo *aInfo)
+{
+    AssertReturn (aInfo, E_FAIL);
+
+    HRESULT rc = S_OK;
+
+    /* We don't return a failure if talking to IErrorInfo fails below to
+     * protect ourselves from bad IErrorInfo implementations (the
+     * corresponding fields will simply remain null in this case). */
+
+    mResultCode = S_OK;
+    rc = aInfo->GetGUID (mIID.asOutParam());
+    AssertComRC (rc);
+    rc = aInfo->GetSource (mComponent.asOutParam());
+    AssertComRC (rc);
+    rc = aInfo->GetDescription (mText.asOutParam());
+    AssertComRC (rc);
+    
+    return S_OK;
+}
+
-// IErrorInfo methods
-////////////////////////////////////////////////////////////////////////////////
@@ -116 +143 @@
-
-#else // !defined (__WIN__)
+
+/**
+ *  Initializes itself by fetching error information from the given error info
+ *  object.
+ */
+HRESULT VirtualBoxErrorInfo::init (nsIException *aInfo)
+{
+    AssertReturn (aInfo, E_FAIL);
+
+    HRESULT rc = S_OK;
+
+    /* We don't return a failure if talking to nsIException fails below to
+     * protect ourselves from bad nsIException implementations (the
+     * corresponding fields will simply remain null in this case). */
+
+    rc = aInfo->GetResult (&mResultCode);
+    AssertComRC (rc);
+    Utf8Str message;
+    rc = aInfo->GetMessage (message.asOutParam());
+    AssertComRC (rc);
+    mText = message;
+    
+    return S_OK;
+}
-
-// nsIException methods

trunk/src/VBox/Main/glue/ErrorInfo.cpp

@@ -20 +20 @@
- */
-
-defined (__WIN__
-
- // !defined (__WIN__)
+!defined (VBOX_WITH_XPCOM
+
+
-
-#include <nsIServiceManager.h>
@@ -28 +28 @@
-#include <nsCOMPtr.h>
-
-
-
-
-
-
+
-
-#include "VBox/com/VirtualBox.h"
-#include "VBox/com/ErrorInfo.h"
-#include "VBox/com/assert.h"
+#include "VBox/com/com.h"
-
-#include <iprt/stream.h>
-#include <iprt/string.h>
+
-#include <VBox/err.h>
-
-/**
- *  Resolves a given interface ID to a string containint interface name.
- *  If, for some reason, the given IID cannot be resolved to a name,
- *  a NULL string is returned. A non-NULL interface name must be freed
- *  using SysFreeString().
- */
-static void GetInterfaceNameByIID (const GUID &id, BSTR *name)
-{
-    Assert (name);
-    if (!name)
-        return;
-
-    *name = NULL;
-
-#if defined (__WIN__)
-
-    LONG rc;
-    LPOLESTR iidStr = NULL;
-    if (StringFromIID (id, &iidStr) == S_OK)
-    {
-        HKEY ifaceKey;
-        rc = RegOpenKeyExW (HKEY_CLASSES_ROOT, L"Interface", 0, KEY_QUERY_VALUE, &ifaceKey);
-        if (rc == ERROR_SUCCESS)
-        {
-            HKEY iidKey;
-            rc = RegOpenKeyExW (ifaceKey, iidStr, 0, KEY_QUERY_VALUE, &iidKey);
-            if (rc == ERROR_SUCCESS)
-            {
-                // determine the size and type
-                DWORD sz, type;
-                rc = RegQueryValueExW (iidKey, NULL, NULL, &type, NULL, &sz);
-                if (rc == ERROR_SUCCESS && type == REG_SZ)
-                {
-                    // query the value to BSTR
-                    *name = SysAllocStringLen (NULL, (sz + 1) / sizeof (TCHAR) + 1);
-                    rc = RegQueryValueExW (iidKey, NULL, NULL, NULL, (LPBYTE) *name, &sz);
-                    if (rc != ERROR_SUCCESS)
-                    {
-                        SysFreeString (*name);
-                        name = NULL;
-                    }
-                }
-                RegCloseKey (iidKey);
-            }
-            RegCloseKey (ifaceKey);
-        }
-        CoTaskMemFree (iidStr);
-    }
-
-#else
-
-    nsresult rv;
-    nsCOMPtr <nsIInterfaceInfoManager> iim =
-        do_GetService (NS_INTERFACEINFOMANAGER_SERVICE_CONTRACTID, &rv);
-    if (NS_SUCCEEDED (rv))
-    {
-        nsCOMPtr <nsIInterfaceInfo> iinfo;
-        rv = iim->GetInfoForIID (&id, getter_AddRefs (iinfo));
-        if (NS_SUCCEEDED (rv))
-        {
-            const char *iname = NULL;
-            iinfo->GetNameShared (&iname);
-            char *utf8IName = NULL;
-            if (VBOX_SUCCESS (RTStrCurrentCPToUtf8 (&utf8IName, iname)))
-            {
-                PRTUCS2 ucs2IName = NULL;
-                if (VBOX_SUCCESS (RTStrUtf8ToUcs2 (&ucs2IName, utf8IName)))
-                {
-                    *name = SysAllocString ((OLECHAR *) ucs2IName);
-                    RTStrUcs2Free (ucs2IName);
-                }
-                RTStrFree (utf8IName);
-            }
-        }
-    }
-
-#endif
-}
-
-
-namespace com
-{
-
-I
+
-////////////////////////////////////////////////////////////////////////////////
-
-
+bool aKeepObj /* = false */
-{
-    HRESULT rc = E_FAIL;
-
-defined (__WIN__
+!defined (VBOX_WITH_XPCOM
-
-    ComPtr <IErrorInfo> err;
@@ -138 +56 @@
-    if (rc == S_OK && err)
-    {
+        if (aKeepObj)
+            mErrorInfo = err;
+
-        ComPtr <IVirtualBoxErrorInfo> info;
-        rc = err.queryInterfaceTo (info.asOutParam());
@@ -165 +86 @@
-    }
-
-__WIN__
+VBOX_WITH_XPCOM
-
-    nsCOMPtr <nsIExceptionService> es;
@@ -179 +100 @@
-            if (NS_SUCCEEDED (rc) && ex)
-            {
+                if (aKeepObj)
+                    mErrorInfo = ex;
+
-                ComPtr <IVirtualBoxErrorInfo> info;
-                rc = ex.queryInterfaceTo (info.asOutParam());
@@ -213 +137 @@
-    AssertComRC (rc);
-
-__WIN__
-
-
-i, const GUID &iid
-
-i
-i
+VBOX_WITH_XPCOM
+
+
+aI, const GUID &aIID, bool aKeepObj /* = false */
+
+aI
+aI
-        return;
-
-defined (__WIN__
-
-i
+!defined (VBOX_WITH_XPCOM
+
+aI
-    ComPtr <ISupportErrorInfo> serr;
-    HRESULT rc = iface.queryInterfaceTo (serr.asOutParam());
-    if (SUCCEEDED (rc))
-    {
-iid
+aIID
-        if (SUCCEEDED (rc))
-(
-
-
- // !defined (__WIN__)
-
-(
-
- // !defined (__WIN__)
+ (aKeepObj
+
+
+
+
+ (aKeepObj
+
+
-
-    if (mIsBasicAvailable)
-    {
-iid
-iid
+aIID
+aIID
-    }
-}
@@ -270 +194 @@
-
-    rc = info->COMGETTER(Text) (mText.asOutParam());
+    gotSomething |= SUCCEEDED (rc);
+    gotAll &= SUCCEEDED (rc);
+
+    ComPtr <IVirtualBoxErrorInfo> next;
+    rc = info->COMGETTER(Next) (next.asOutParam());
+    if (SUCCEEDED (rc) && !next.isNull())
+    {
+        mNext.reset (new ErrorInfo (next));
+        Assert (mNext.get());
+        if (!mNext.get())
+            rc = E_OUTOFMEMORY;
+    }
+    else
+        mNext.reset();
-    gotSomething |= SUCCEEDED (rc);
-    gotAll &= SUCCEEDED (rc);
@@ -300 +238 @@
-}
-
-
+
+
+
+
+
+
+
+
+
+
+
+
-////////////////////////////////////////////////////////////////////////////////
-
-ProgressErrorInfo::ProgressErrorInfo (IProgress *progress) :
-true
+false /* aDummy */
-{
-    Assert (progress);
@@ -316 +265 @@
-}
-
+// ErrorInfoKeeper class
+////////////////////////////////////////////////////////////////////////////////
+
+HRESULT ErrorInfoKeeper::restore()
+{
+    if (mForgot)
+        return S_OK;
+
+    HRESULT rc = S_OK;
+
+#if !defined (VBOX_WITH_XPCOM)
+
+    ComPtr <IErrorInfo> err;
+    if (!mErrorInfo.isNull())
+    {
+        rc = mErrorInfo.queryInterfaceTo (err.asOutParam());
+        AssertComRC (rc);
+    }
+    rc = ::SetErrorInfo (0, err);
+
+#else // !defined (VBOX_WITH_XPCOM)
+
+    nsCOMPtr <nsIExceptionService> es;
+    es = do_GetService (NS_EXCEPTIONSERVICE_CONTRACTID, &rc);
+    if (NS_SUCCEEDED (rc))
+    {
+        nsCOMPtr <nsIExceptionManager> em;
+        rc = es->GetCurrentExceptionManager (getter_AddRefs (em));
+        if (NS_SUCCEEDED (rc))
+        {
+            ComPtr <nsIException> ex;
+            if (!mErrorInfo.isNull())
+            {
+                rc = mErrorInfo.queryInterfaceTo (ex.asOutParam());
+                AssertComRC (rc);
+            }
+            rc = em->SetCurrentException (ex);
+        }
+    }
+
+#endif // !defined (VBOX_WITH_XPCOM)
+
+    if (SUCCEEDED (rc))
+    {
+        mErrorInfo.setNull();
+        mForgot = true;
+    }
+
+    return rc;
+}
+
-}; // namespace com
-

trunk/src/VBox/Main/glue/com.cpp

@@ -20 +20 @@
- */
-
-defined (__WIN__
+!defined (VBOX_WITH_XPCOM
-
-#include <objbase.h>
-
- // !defined (__WIN__)
+
-
-#include <stdlib.h>
@@ -36 +36 @@
-#include <nsEventQueueUtils.h>
-
-
+
+
+
+
+
+
+
-
-#include "VBox/com/com.h"
@@ -48 +54 @@
-    HRESULT rc = E_FAIL;
-
-
+
+
-    rc = CoInitializeEx (NULL, COINIT_MULTITHREADED |
-                               COINIT_DISABLE_OLE1DDE |
-                               COINIT_SPEED_OVER_MEMORY);
-
-
-
-
+
+
+
+/* Set VBOX_XPCOM_HOME if not present
-    if (!getenv("VBOX_XPCOM_HOME"))
-    {
@@ -82 +89 @@
-        }
-    }
+
-#endif
-
@@ -91 +99 @@
-void Shutdown()
-{
-
+
+
-    CoUninitialize();
-
+
+
+
-    nsCOMPtr <nsIEventQueue> eventQ;
-    nsresult rc = NS_GetMainEventQ (getter_AddRefs (eventQ));
@@ -100 +111 @@
-        BOOL isOnMainThread = FALSE;
-        eventQ->IsOnCurrentThread (&isOnMainThread);
-/ early release
+* early release */
-        if (isOnMainThread)
-        {
-/ only the main thread needs to uninitialize XPCOM
+* only the main thread needs to uninitialize XPCOM */
-            NS_ShutdownXPCOM (nsnull);
-            XPCOMGlueShutdown();
-        }
-    }
+
-#endif
-}
-
+void GetInterfaceNameByIID (const GUID &aIID, BSTR *aName)
+{
+    Assert (aName);
+    if (!aName)
+        return;
+
+    *aName = NULL;
+
+#if !defined (VBOX_WITH_XPCOM)
+
+    LONG rc;
+    LPOLESTR iidStr = NULL;
+    if (StringFromIID (aIID, &iidStr) == S_OK)
+    {
+        HKEY ifaceKey;
+        rc = RegOpenKeyExW (HKEY_CLASSES_ROOT, L"Interface",
+                            0, KEY_QUERY_VALUE, &ifaceKey);
+        if (rc == ERROR_SUCCESS)
+        {
+            HKEY iidKey;
+            rc = RegOpenKeyExW (ifaceKey, iidStr, 0, KEY_QUERY_VALUE, &iidKey);
+            if (rc == ERROR_SUCCESS)
+            {
+                /* determine the size and type */
+                DWORD sz, type;
+                rc = RegQueryValueExW (iidKey, NULL, NULL, &type, NULL, &sz);
+                if (rc == ERROR_SUCCESS && type == REG_SZ)
+                {
+                    /* query the value to BSTR */
+                    *aName = SysAllocStringLen (NULL, (sz + 1) /
+                                                      sizeof (TCHAR) + 1);
+                    rc = RegQueryValueExW (iidKey, NULL, NULL, NULL,
+                                           (LPBYTE) *aName, &sz);
+                    if (rc != ERROR_SUCCESS)
+                  &n