VirtualBox

Changeset 2247

Show
Ignore:
Timestamp:
04/19/07 23:40:41 (2 years ago)
Author:
vboxsync
Message:

r=bird: ASMMemoryClobber questions.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • trunk/include/iprt/asm.h

    r2245 r2247  
    15091509 * for assembler instructions with side-effects, e.g. port writes to magical guest ports causing 
    15101510 * guest memory changes by the host 
     1511 * 
     1512 * @todo r=bird: There are two things I don't like there, 1) the name and 2) what about msc? 
     1513 * 
     1514 *      Unless I'm not much mistaken this construct is what is 'barrier' or 'mb' in the linux  
     1515 *      kernel. The ASMMem is used as prefix elsewhere in this file, so ASMMemory* is a confusing 
     1516 *      way to name a new function. I think a more fitting name would be ASMCompilerBarrier,  
     1517 *      ASMCompilerMemoryBarrier, or perhaps ASMMemBarrier. 
     1518 * 
     1519 *      For MSC I guess _ReadWriteBarrier is what we're looking for.  
     1520 *      See http://msdn2.microsoft.com/en-us/library/f20w0x5e(VS.80).aspx 
     1521 * 
     1522 *      We should also add a little note about considering using 'volatile' similar to the one found  
     1523 *      with the _ReadWriteBarrier docs. 
    15111524 */ 
    15121525#if RT_INLINE_ASM_GNU_STYLE 

© 2008 Sun Microsystems, Inc.
ContactPrivacy policy